-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 I2S 8/16 bits parallel channel support (WIP) #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makuna
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some comment additions, one allocation move.
Also, make sure no tabs, tabs should be replaced with 4 spaces. Not that I had seen any, but the review tool doesn't make it easy to spot them.
Makuna
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is based on Makuna Esp32I2sX parallel development branch. I added some critical bug fixes and now the library is able to generate a well-formed signal using parallel output (still clock needs to be adjusted). Due to limitation 'true' 8 bits parallel mode is only available for i2s1 interface (NeoEsp32I2s1X8Ws2812Method). For ESP32/16bit mode there is a method NeoEsp32I2s0X16Ws2812Method, and for ESP32S2 (tested with mini lolin) NeoEsp32I2s0X8Ws2812Method: this method is 8 channels but it's working with 16 bits sample DMA. Both NeoEsp32I2s0X16Ws2812Method and NeoEsp32I2s0X8Ws2812Method are using I2S0 interface.
To do: