Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Installing from URL (not from source) #78

Closed
juharris opened this issue Jul 8, 2019 · 0 comments
Closed

Support Installing from URL (not from source) #78

juharris opened this issue Jul 8, 2019 · 0 comments
Assignees
@temporaer
Labels
enhancement

Comments

@juharris
Copy link
Contributor

juharris commented Jul 8, 2019

Support pip install nlg-eval@git+https://github.com/Maluuba/nlg-eval.git

See #50 #77 for reported issues.
@juharris juharris mentioned this issue Jul 8, 2019
Closed
@temporaer temporaer self-assigned this Jul 8, 2019
temporaer added a commit that referenced this issue Jul 11, 2019
@temporaer
allow nlg-eval --setup to work from anywhere. Fixes #78
e0d6743 
nlg-eval --setup now takes a path as an argument or "default".

During setup,

- The code location is inferred from the package directory.
- The data location is stored in a config file, so that it does not have
  to be provided again.

A common function (`nlgeval.utils.get_data_dir()`) provides
(rudimentarily checked) access to the data location via environment
variable or config file (in this order). Added some colorful hints
as to where data is stored to setup/CLI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@temporaer temporaer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@temporaer @juharris