Feat: Add randomness to the codeql scanning time #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do we need this change? ======================= If deploying across a large number of repositories having all jobs trigger at the same exact time causes a mass spike in potential workloads on self hosted runners. Change behaviors to randomize the time as we want to get the results weekly, but timing shouldn't entirely matter What effects does this change have? ======================= * include secrets to generate random time * add randomness to the cron task * various lint fixes Signed-off-by: Joshua Jackson <joshua.jackson@employinc.com>
JoshuaJackson-jobvite
force-pushed
the
jjackson/randomness_cron
branch
from
83fea4c to
c70df23
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Thank you @JoshuaJackson-jobvite ! It's something that has been on my radar for a while, so I really appreciate your contribution :) I will draft a new release this week including your changes. |
jboursier-mwb
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this change?
If deploying across a large number of repositories having all jobs trigger at the same exact time causes a mass spike in potential workloads on self hosted runners. Change behaviors to randomize the time as we want to get the results weekly, but timing shouldn't entirely matter
What effects does this change have?