warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:352:9 | 352 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:345:9 | 345 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:338:9 | 338 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:331:9 | 331 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:324:9 | 324 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:317:9 | 317 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:289:9 | 289 | unimplemented!(); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:282:9 | 282 | unimplemented!(); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:246:9 | 246 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:238:9 | 238 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:230:9 | 230 | unimplemented!(); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/transaction_manager.rs#L503

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/transaction_manager.rs:503:18 | 503 | .zip(input_object_cache_misses.into_iter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `input_object_cache_misses` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

use of `default` to create a unit struct: crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs#L203

warning: use of `default` to create a unit struct --> crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs:203:44 | 203 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs#L141

warning: use of `default` to create a unit struct --> crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs:141:44 | 141 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/unit_tests/consensus_tests.rs:201:9 | 201 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/mod.rs#L1146

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/checkpoints/mod.rs:1146:22 | 1146 | .zip(pending.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `pending` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs#L957

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs:957:18 | 957 | .zip(expected_effects_digests.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `expected_effects_digests` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs#L939

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs:939:18 | 939 | .zip(expected_effects_digests.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `expected_effects_digests` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

redundant pattern matching, consider using `is_none()`: crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs#L294

warning: redundant pattern matching, consider using `is_none()` --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:294:13 | 294 | assert!(matches!( | _____________^ 295 | | checkpoint_store 296 | | .get_highest_executed_checkpoint_seq_number() 297 | | .unwrap(), 298 | | None, 299 | | )); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching help: try this | 294 ~ assert!(checkpoint_store 295 + .get_highest_executed_checkpoint_seq_number() 296 ~ .unwrap().is_none()); |

redundant pattern matching, consider using `is_none()`: crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs#L130

warning: redundant pattern matching, consider using `is_none()` --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:130:13 | 130 | assert!(matches!( | _____________^ 131 | | checkpoint_store 132 | | .get_highest_executed_checkpoint_seq_number() 133 | | .unwrap(), 134 | | None, 135 | | )); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching help: try this | 130 ~ assert!(checkpoint_store 131 + .get_highest_executed_checkpoint_seq_number() 132 ~ .unwrap().is_none()); |

redundant pattern matching, consider using `is_none()`: crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs#L41

warning: redundant pattern matching, consider using `is_none()` --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:41:13 | 41 | assert!(matches!( | _____________^ 42 | | checkpoint_store 43 | | .get_highest_executed_checkpoint_seq_number() 44 | | .unwrap(), 45 | | None, 46 | | )); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default help: try this | 41 ~ assert!(checkpoint_store 42 + .get_highest_executed_checkpoint_seq_number() 43 ~ .unwrap().is_none()); |

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority_aggregator.rs#L1771

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/authority_aggregator.rs:1771:33 | 1771 | .extend(fastpath_input_objects.into_iter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `fastpath_input_objects` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-cluster-test/src/cluster.rs:282:9 | 282 | / unreachable!( 283 | | "If we already have a boxed Cluster trait object we wouldn't have to call this function" 284 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unreachable` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority/authority_notify_read.rs#L103

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/authority/authority_notify_read.rs:103:18 | 103 | .zip(registrations.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `registrations` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority/authority_notify_read.rs#L58

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-core/src/authority/authority_notify_read.rs:58:18 | 58 | .zip(registrations.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `registrations` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L772

warning: sub-expression diverges --> crates/sui-e2e-tests/tests/dynamic_committee_tests.rs:345:13 | 345 | todo!() | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)

you seem to be trying to pop elements from a `Vec` in a loop: crates/sui-e2e-tests/tests/reconfiguration_tests.rs#L598

warning: you seem to be trying to pop elements from a `Vec` in a loop --> crates/sui-e2e-tests/tests/reconfiguration_tests.rs:598:9 | 598 | let v1 = candidates.pop().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some = note: `#[warn(clippy::manual_while_let_some)]` on by default help: consider using a `while..let` loop | 597 ~ while let Some(v1) = candidates.pop() { 598 ~ |

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-benchmark/src/lib.rs:346:9 | 346 | unimplemented!("Not available for local proxy"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: crates/sui-benchmark/src/workloads/transfer_object.rs#L198

warning: sub-expression diverges --> crates/sui-benchmark/src/workloads/transfer_object.rs:198:9 | 198 | return; | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default

use of `default` to create a unit struct: crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs#L822

warning: use of `default` to create a unit struct --> crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs:822:27 | 822 | .choose(&mut OsRng::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs#L811

warning: use of `default` to create a unit struct --> crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs:811:27 | 811 | .choose(&mut OsRng::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

use of `default` to create a unit struct: crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs#L187

warning: use of `default` to create a unit struct --> crates/sui-rosetta/src/unit_tests/balance_changing_tx_tests.rs:187:49 | 187 | let recipient = *addresses.choose(&mut OsRng::default()).unwrap(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

sub-expression diverges: crates/sui-benchmark/src/workloads/transfer_object.rs#L198

variable does not need to be mutable: crates/sui-rosetta/src/operations.rs#L67

warning: variable does not need to be mutable --> crates/sui-rosetta/src/operations.rs:67:21 | 67 | for (index, mut op) in ops.iter_mut().enumerate() { | ----^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/stake.rs:13:9 | 13 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

variable does not need to be mutable: crates/sui-benchmark/src/bank.rs#L101

warning: variable does not need to be mutable --> crates/sui-benchmark/src/bank.rs:101:9 | 101 | mut init_coin: &mut Gas, | ----^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/owner.rs:162:9 | 162 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/owner.rs:152:9 | 152 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/owner.rs:148:9 | 148 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/owner.rs:138:9 | 138 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/owner.rs:127:9 | 127 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/object.rs:156:9 | 156 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/object.rs:146:9 | 146 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/object.rs:142:9 | 142 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/object.rs:132:9 | 132 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/object.rs:121:9 | 121 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/coin.rs:13:9 | 13 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:114:9 | 114 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:104:9 | 104 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:100:9 | 100 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:90:9 | 90 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:79:9 | 79 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-graphql-rpc/src/types/address.rs:43:9 | 43 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

useless use of `vec!`: crates/sui-tool/src/db_tool/mod.rs#L493

warning: useless use of `vec!` --> crates/sui-tool/src/db_tool/mod.rs:493:21 | 493 | let quantiles = vec![25, 50, 75, 90, 99]; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[25, 50, 75, 90, 99]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default

useless use of `vec!`: crates/sui-tool/src/db_tool/mod.rs#L493

unnecessary hashes around raw string literal: crates/sui-indexer/src/store/pg_indexer_store.rs#L75

warning: unnecessary hashes around raw string literal --> crates/sui-indexer/src/store/pg_indexer_store.rs:75:33 | 75 | const GET_PARTITION_SQL: &str = r#" | _________________________________^ 76 | | SELECT parent.relname AS table_name, 77 | | MAX(SUBSTRING(child.relname FROM '\d$')) AS last_partition 78 | | FROM pg_inherits ... | 84 | | GROUP BY table_name; 85 | | "#; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes = note: `#[warn(clippy::needless_raw_string_hashes)]` on by default help: try | 75 ~ const GET_PARTITION_SQL: &str = r" 76 + SELECT parent.relname AS table_name, 77 + MAX(SUBSTRING(child.relname FROM '\d$')) AS last_partition 78 + FROM pg_inherits 79 + JOIN pg_class parent ON pg_inherits.inhparent = parent.oid 80 + JOIN pg_class child ON pg_inherits.inhrelid = child.oid 81 + JOIN pg_namespace nmsp_parent ON nmsp_parent.oid = parent.relnamespace 82 + JOIN pg_namespace nmsp_child ON nmsp_child.oid = child.relnamespace 83 + WHERE parent.relkind = 'p' 84 + GROUP BY table_name; 85 ~ "; |

sub-expression diverges: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.71/src/macros.rs#L58

warning: sub-expression diverges --> crates/sui-transactional-test-runner/src/test_adapter.rs:573:9 | 573 | bail!("Resource viewing is not supported") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.71/src/macros.rs#L58

warning: sub-expression diverges --> crates/sui-transactional-test-runner/src/test_adapter.rs:563:9 | 563 | bail!("Scripts are not supported") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.71/src/macros.rs#L58

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L349

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:83:16 | 83 | let leaf = prop_oneof![ | ________________^ 84 | | any::<TypeTag>(), 85 | | base_type_factory_tag_gen(type_factory_addr), 86 | | nested_type_factory_tag_gen(type_factory_addr), 87 | | ]; | |_____^ | = note: the trait `Send` is not implemented for `impl Strategy<Value = TypeTag>` = note: the trait `Sync` is not implemented for `impl Strategy<Value = TypeTag>` = note: required for `Arc<impl Strategy<Value = TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L347

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:83:16 | 83 | let leaf = prop_oneof![ | ________________^ 84 | | any::<TypeTag>(), 85 | | base_type_factory_tag_gen(type_factory_addr), 86 | | nested_type_factory_tag_gen(type_factory_addr), 87 | | ]; | |_____^ | = note: the trait `Send` is not implemented for `BoxedStrategy<TypeTag>` = note: the trait `Sync` is not implemented for `BoxedStrategy<TypeTag>` = note: required for `Arc<BoxedStrategy<TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L340

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:70:16 | 70 | let leaf = prop_oneof![ | ________________^ 71 | | base_type_factory_tag_gen(type_factory_addr), 72 | | nested_type_factory_tag_gen(type_factory_addr), 73 | | ]; | |_____^ | = note: the trait `Send` is not implemented for `impl Strategy<Value = TypeTag>` = note: the trait `Sync` is not implemented for `impl Strategy<Value = TypeTag>` = note: required for `Arc<impl Strategy<Value = TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L340

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:45:9 | 45 | / prop_oneof![ 46 | | inner.prop_map(|x| TypeTag::Vector(Box::new(x))), 47 | | gen_struct_tag().prop_map(|x| TypeTag::Struct(Box::new(x))), 48 | | ] | |_________^ | = note: the trait `Send` is not implemented for `Map<impl Strategy<Value = StructTag>, [closure@type_arg_fuzzer.rs:47:39]>` = note: the trait `Sync` is not implemented for `Map<impl Strategy<Value = StructTag>, [closure@type_arg_fuzzer.rs:47:39]>` = note: required for `Arc<Map<impl Strategy<Value = StructTag>, [closure@type_arg_fuzzer.rs:47:39]>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L339

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:45:9 | 45 | / prop_oneof![ 46 | | inner.prop_map(|x| TypeTag::Vector(Box::new(x))), 47 | | gen_struct_tag().prop_map(|x| TypeTag::Struct(Box::new(x))), 48 | | ] | |_________^ | = note: the trait `Send` is not implemented for `Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>` = note: the trait `Sync` is not implemented for `Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>` = note: required for `Arc<Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L340

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:25:5 | 25 | / prop_oneof![ 26 | | 2 => any::<TypeTag>(), 27 | | 1 => gen_nested_type_tag() 28 | | ] | |_____^ | = note: the trait `Send` is not implemented for `impl Strategy<Value = TypeTag>` = note: the trait `Sync` is not implemented for `impl Strategy<Value = TypeTag>` = note: required for `Arc<impl Strategy<Value = TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L339

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:25:5 | 25 | / prop_oneof![ 26 | | 2 => any::<TypeTag>(), 27 | | 1 => gen_nested_type_tag() 28 | | ] | |_____^ | = note: the trait `Send` is not implemented for `BoxedStrategy<TypeTag>` = note: the trait `Sync` is not implemented for `BoxedStrategy<TypeTag>` = note: required for `Arc<BoxedStrategy<TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L349

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/account_universe/transfer_gen.rs:567:5 | 567 | / prop_oneof![ 568 | | 3 => any_with::<P2PTransferGenGoodGas>((min, max)).prop_map(P2PTransferGenGoodGas::arced), 569 | | 2 => any_with::<P2PTransferGenRandomGasRandomPrice>((min, max)).prop_map(P2PTransferGenRandomGasRandomPrice::arced), 570 | | 1 => any_with::<P2PTransferGenRandomGas>((min, max)).prop_map(P2PTransferGenRandomGas::arced), 571 | | ] | |_____^ | = note: the trait `Send` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64)) -> P2PTransferGenRandomGas>, fn(P2PTransferGenRandomGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGas as AUTransactionGen>::arced}>` = note: the trait `Sync` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64)) -> P2PTransferGenRandomGas>, fn(P2PTransferGenRandomGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGas as AUTransactionGen>::arced}>` = note: required for `Arc<Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64)) -> P2PTransferGenRandomGas>, fn(P2PTransferGenRandomGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGas as AUTransactionGen>::arced}>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L348

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/account_universe/transfer_gen.rs:567:5 | 567 | / prop_oneof![ 568 | | 3 => any_with::<P2PTransferGenGoodGas>((min, max)).prop_map(P2PTransferGenGoodGas::arced), 569 | | 2 => any_with::<P2PTransferGenRandomGasRandomPrice>((min, max)).prop_map(P2PTransferGenRandomGasRandomPrice::arced), 570 | | 1 => any_with::<P2PTransferGenRandomGas>((min, max)).prop_map(P2PTransferGenRandomGas::arced), 571 | | ] | |_____^ | = note: the trait `Send` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>` = note: the trait `Sync` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>` = note: required for `Arc<Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L347

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/account_universe/transfer_gen.rs:567:5 | 567 | / prop_oneof![ 568 | | 3 => any_with::<P2PTransferGenGoodGas>((min, max)).prop_map(P2PTransferGenGoodGas::arced), 569 | | 2 => any_with::<P2PTransferGenRandomGasRandomPrice>((min, max)).prop_map(P2PTransferGenRandomGasRandomPrice::arced), 570 | | 1 => any_with::<P2PTransferGenRandomGas>((min, max)).prop_map(P2PTransferGenRandomGas::arced), 571 | | ] | |_____^ | = note: the trait `Send` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>` = note: the trait `Sync` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>` = note: required for `Arc<Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

variable does not need to be mutable: crates/sui-benchmark/src/bank.rs#L101

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L349

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L347

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:83:16 | 83 | let leaf = prop_oneof![ | ________________^ 84 | | any::<TypeTag>(), 85 | | base_type_factory_tag_gen(type_factory_addr), 86 | | nested_type_factory_tag_gen(type_factory_addr), 87 | | ]; | |_____^ | = note: the trait `Send` is not implemented for `BoxedStrategy<TypeTag>` = note: the trait `Sync` is not implemented for `BoxedStrategy<TypeTag>` = note: required for `Arc<BoxedStrategy<TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L340

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L339

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:45:9 | 45 | / prop_oneof![ 46 | | inner.prop_map(|x| TypeTag::Vector(Box::new(x))), 47 | | gen_struct_tag().prop_map(|x| TypeTag::Struct(Box::new(x))), 48 | | ] | |_________^ | = note: the trait `Send` is not implemented for `Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>` = note: the trait `Sync` is not implemented for `Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>` = note: required for `Arc<Map<BoxedStrategy<TypeTag>, [closure@type_arg_fuzzer.rs:46:28]>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `$crate::prop_oneof` which comes from the expansion of the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L340

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L339

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/type_arg_fuzzer.rs:25:5 | 25 | / prop_oneof![ 26 | | 2 => any::<TypeTag>(), 27 | | 1 => gen_nested_type_tag() 28 | | ] | |_____^ | = note: the trait `Send` is not implemented for `BoxedStrategy<TypeTag>` = note: the trait `Sync` is not implemented for `BoxedStrategy<TypeTag>` = note: required for `Arc<BoxedStrategy<TypeTag>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L349

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L348

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/account_universe/transfer_gen.rs:567:5 | 567 | / prop_oneof![ 568 | | 3 => any_with::<P2PTransferGenGoodGas>((min, max)).prop_map(P2PTransferGenGoodGas::arced), 569 | | 2 => any_with::<P2PTransferGenRandomGasRandomPrice>((min, max)).prop_map(P2PTransferGenRandomGasRandomPrice::arced), 570 | | 1 => any_with::<P2PTransferGenRandomGas>((min, max)).prop_map(P2PTransferGenRandomGas::arced), 571 | | ] | |_____^ | = note: the trait `Send` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>` = note: the trait `Sync` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>` = note: required for `Arc<Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>, BoxedStrategy<u64>, BoxedStrategy<u64>), fn((AccountPairGen, u64, u64, u64)) -> P2PTransferGenRandomGasRandomPrice>, fn(P2PTransferGenRandomGasRandomPrice) -> Arc<dyn AUTransactionGen> {<P2PTransferGenRandomGasRandomPrice as AUTransactionGen>::arced}>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

usage of an `Arc` that is not `Send` or `Sync`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.1.0/src/sugar.rs#L347

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/transaction-fuzzer/src/account_universe/transfer_gen.rs:567:5 | 567 | / prop_oneof![ 568 | | 3 => any_with::<P2PTransferGenGoodGas>((min, max)).prop_map(P2PTransferGenGoodGas::arced), 569 | | 2 => any_with::<P2PTransferGenRandomGasRandomPrice>((min, max)).prop_map(P2PTransferGenRandomGasRandomPrice::arced), 570 | | 1 => any_with::<P2PTransferGenRandomGas>((min, max)).prop_map(P2PTransferGenRandomGas::arced), 571 | | ] | |_____^ | = note: the trait `Send` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>` = note: the trait `Sync` is not implemented for `Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>` = note: required for `Arc<Map<Map<(Map<(UniformArrayStrategy<Map<IndexStrategy, fn(Index) -> Index>, [Index; 3]>, Any), fn(([Index; 3], bool)) -> AccountPairGen>, BoxedStrategy<u64>), fn((AccountPairGen, u64)) -> P2PTransferGenGoodGas>, fn(P2PTransferGenGoodGas) -> Arc<dyn AUTransactionGen> {<P2PTransferGenGoodGas as AUTransactionGen>::arced}>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default = note: this warning originates in the macro `prop_oneof` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

unnecessary hashes around raw string literal: crates/sui-core/src/unit_tests/move_package_publish_tests.rs#L208

warning: unnecessary hashes around raw string literal --> crates/sui-core/src/unit_tests/move_package_publish_tests.rs:208:29 | 208 | let expected = expect![[r##" | _____________________________^ 209 | | # @generated by Move, please check-in and do not edit manually. 210 | | 211 | | [move] ... | 238 | | ] 239 | | "##]]; | |_______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes = note: `#[warn(clippy::needless_raw_string_hashes)]` on by default help: try | 208 ~ let expected = expect![[r#" 209 + # @generated by Move, please check-in and do not edit manually. 210 + 211 + [move] 212 + version = 0 213 + manifest_digest = "1401DE1C3C3FF6D20EB27741A0A7B5D61E34836CB6C90ECC2F2DE97C47B4D0F9" 214 + 215 + dependencies = [ 216 + { name = "Examples" }, 217 + { name = "Sui" }, 218 + ] 219 + 220 + [[move.package]] 221 + name = "Examples" 222 + source = { local = "../object_basics" } 223 + 224 + dependencies = [ 225 + { name = "Sui" }, 226 + ] 227 + 228 + [[move.package]] 229 + name = "MoveStdlib" 230 + source = { local = "../../../../../sui-framework/packages/move-stdlib" } 231 + 232 + [[move.package]] 233 + name = "Sui" 234 + source = { local = "../../../../../sui-framework/packages/sui-framework" } 235 + 236 + dependencies = [ 237 + { name = "MoveStdlib" }, 238 + ] 239 ~ "#]]; |

unnecessary hashes around raw string literal: crates/sui-indexer/src/store/pg_indexer_store.rs#L75

variable does not need to be mutable: crates/sui-rosetta/src/operations.rs#L67

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-replay/src/data_fetcher.rs:758:9 | 758 | unimplemented!("get_epoch_change_events for state dump is not implemented") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-replay/src/data_fetcher.rs:741:9 | 741 | unimplemented!("fetch_random_tx for state dump is not implemented") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-replay/src/data_fetcher.rs:732:9 | 732 | unimplemented!("get_latest_checkpoint_sequence_number for state dump is not implemented") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-replay/src/data_fetcher.rs:715:9 | 715 | unimplemented!("get_transaction for state dump is not implemented") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> crates/sui-replay/src/data_fetcher.rs:708:9 | 708 | unimplemented!("get_checkpoint_txs for state dump is not implemented") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-storage/tests/key_value_tests.rs#L96

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-storage/tests/key_value_tests.rs:96:13 | 96 | [ExecutionDigests::random()].into_iter(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[ExecutionDigests::random()]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /runner/_work/sui/sui/crates/sui-types/src/messages_checkpoint.rs:334:12 | 334 | T: IntoIterator<Item = ExecutionDigests>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> crates/sui-core/src/test_authority_clients.rs:230:9 | 230 | unimplemented!(); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/transaction_manager.rs#L503

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/mod.rs#L1146

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs#L957

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs#L939

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority_aggregator.rs#L1771

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority/authority_notify_read.rs#L103

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-core/src/authority/authority_notify_read.rs#L58

variable does not need to be mutable: crates/sui-swarm-config/tests/snapshot_tests.rs#L121

warning: variable does not need to be mutable --> crates/sui-swarm-config/tests/snapshot_tests.rs:121:9 | 121 | for mut validator_config in &mut network_config.validator_configs { | ----^^^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-swarm-config/src/network_config_builder.rs#L207

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-swarm-config/src/network_config_builder.rs:207:26 | 207 | .zip(protocol_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `protocol_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-swarm-config/src/network_config_builder.rs#L207

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-genesis-builder/src/lib.rs#L953

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-genesis-builder/src/lib.rs:953:14 | 953 | .zip(dependency_objects.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `dependency_objects` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-genesis-builder/src/lib.rs#L953

useless use of `vec!`: crates/sui-json/src/tests.rs#L599

warning: useless use of `vec!` --> crates/sui-json/src/tests.rs:599:16 | 599 | let args = vec![object_id, addr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[object_id, addr]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

useless use of `vec!`: crates/sui-json/src/tests.rs#L563

warning: useless use of `vec!` --> crates/sui-json/src/tests.rs:563:16 | 563 | let args = vec![value, addr] | ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[value, addr]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default

useless use of `vec!`: narwhal/primary/src/tests/primary_tests.rs#L257

warning: useless use of `vec!` --> narwhal/primary/src/tests/primary_tests.rs:257:29 | 257 | let expected_peer_ids = vec![&primary_1_peer_id, &worker_1_peer_id]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&primary_1_peer_id, &worker_1_peer_id]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

useless use of `vec!`: narwhal/primary/src/tests/primary_tests.rs#L237

warning: useless use of `vec!` --> narwhal/primary/src/tests/primary_tests.rs:237:29 | 237 | let expected_peer_ids = vec![&primary_2_peer_id, &worker_1_peer_id]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&primary_2_peer_id, &worker_1_peer_id]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default

use of `default` to create a unit struct: narwhal/primary/src/tests/primary_tests.rs#L121

warning: use of `default` to create a unit struct --> narwhal/primary/src/tests/primary_tests.rs:121:36 | 121 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> narwhal/primary/src/tests/certificate_fetcher_tests.rs:58:9 | 58 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic.rs#L61

warning: sub-expression diverges --> narwhal/primary/src/tests/certificate_fetcher_tests.rs:48:9 | 48 | / unimplemented!( 49 | | "FetchCertificateProxy::send_certificate() is unimplemented!! {:#?}", 50 | | request 51 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

useless use of `vec!`: narwhal/worker/src/tests/worker_tests.rs#L633

warning: useless use of `vec!` --> narwhal/worker/src/tests/worker_tests.rs:633:29 | 633 | let expected_peer_ids = vec![&primary_1_peer_id, &primary_2_peer_id, &worker_1_peer_id]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&primary_1_peer_id, &primary_2_peer_id, &worker_1_peer_id]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

useless use of `vec!`: narwhal/worker/src/tests/worker_tests.rs#L612

warning: useless use of `vec!` --> narwhal/worker/src/tests/worker_tests.rs:612:29 | 612 | let expected_peer_ids = vec![&primary_1_peer_id, &primary_2_peer_id, &worker_2_peer_id]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&primary_1_peer_id, &primary_2_peer_id, &worker_2_peer_id]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

use of `default` to create a unit struct: narwhal/worker/src/tests/worker_tests.rs#L563

warning: use of `default` to create a unit struct --> narwhal/worker/src/tests/worker_tests.rs:563:36 | 563 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

useless use of `vec!`: narwhal/worker/src/tests/worker_tests.rs#L496

warning: useless use of `vec!` --> narwhal/worker/src/tests/worker_tests.rs:496:29 | 496 | let expected_peer_ids = vec![&primary_1_peer_id]; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&primary_1_peer_id]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default

use of `default` to create a unit struct: narwhal/worker/src/tests/worker_tests.rs#L448

warning: use of `default` to create a unit struct --> narwhal/worker/src/tests/worker_tests.rs:448:36 | 448 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: narwhal/worker/src/tests/worker_tests.rs#L307

warning: use of `default` to create a unit struct --> narwhal/worker/src/tests/worker_tests.rs:307:36 | 307 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: narwhal/worker/src/tests/worker_tests.rs#L188

warning: use of `default` to create a unit struct --> narwhal/worker/src/tests/worker_tests.rs:188:36 | 188 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

sub-expression diverges: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/eyre-0.6.8/src/macros.rs#L54

warning: sub-expression diverges --> narwhal/worker/src/tests/worker_tests.rs:47:9 | 47 | eyre::bail!("Invalid batch"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `eyre::bail` (in Nightly builds, run with -Z macro-backtrace for more info)

you seem to be trying to pop elements from a `Vec` in a loop: narwhal/consensus/src/tests/randomized_tests.rs#L654

warning: you seem to be trying to pop elements from a `Vec` in a loop --> narwhal/consensus/src/tests/randomized_tests.rs:654:17 | 654 | let c = children.pop().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some = note: `#[warn(clippy::manual_while_let_some)]` on by default help: consider using a `while..let` loop | 653 ~ while let Some(c) = children.pop() { 654 ~ |

useless use of `vec!`: crates/sui-upgrade-compatibility-transactional-tests/tests/tests.rs#L57

warning: useless use of `vec!` --> crates/sui-upgrade-compatibility-transactional-tests/tests/tests.rs:57:31 | 57 | let compatibility_types = vec![ | _______________________________^ 58 | | // Full compat 59 | | Compatibility::full_check(), 60 | | // Full compat but allow private entry functions to change ... | 87 | | Compatibility::no_check(), 88 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default help: you can use an array directly | 57 ~ let compatibility_types = [Compatibility::full_check(), 58 + // Full compat but allow private entry functions to change 59 + Compatibility { 60 + check_struct_and_pub_function_linking: true, 61 + check_struct_layout: true, 62 + check_friend_linking: true, 63 + check_private_entry_linking: false, 64 + disallowed_new_abilities: AbilitySet::ALL, 65 + disallow_change_struct_type_params: true, 66 + }, 67 + // Full compat but allow private entry functions and friends to change 68 + Compatibility { 69 + check_struct_and_pub_function_linking: true, 70 + check_struct_layout: true, 71 + check_friend_linking: false, 72 + check_private_entry_linking: false, 73 + disallowed_new_abilities: AbilitySet::ALL, 74 + disallow_change_struct_type_params: true, 75 + }, 76 + // Full compat but allow friends to change 77 + Compatibility { 78 + check_struct_and_pub_function_linking: true, 79 + check_struct_layout: true, 80 + check_friend_linking: false, 81 + check_private_entry_linking: true, 82 + disallowed_new_abilities: AbilitySet::ALL, 83 + disallow_change_struct_type_params: true, 84 + }, 85 ~ Compatibility::no_check()]; |

usage of `Iterator::fold` on a type that implements `Try`: narwhal/config/src/committee.rs#L412

warning: usage of `Iterator::fold` on a type that implements `Try` --> narwhal/config/src/committee.rs:412:14 | 412 | .fold(Ok(BTreeMap::new()), |acc, (pk, authority)| { | ______________^ 413 | | if let Some((stake, address)) = new_info.remove(pk) { 414 | | if stake == authority.stake { 415 | | match acc { ... | 439 | | } 440 | | }); | |______________^ help: use `try_fold` instead: `try_fold(BTreeMap::new(), |acc, (pk, authority)| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

use of `default` to create a unit struct: narwhal/node/src/main.rs#L322

warning: use of `default` to create a unit struct --> narwhal/node/src/main.rs:322:48 | 322 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

use of `default` to create a unit struct: narwhal/node/tests/node_test.rs#L73

warning: use of `default` to create a unit struct --> narwhal/node/tests/node_test.rs:73:40 | 73 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

useless use of `vec!`: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-2.34.0/src/macros.rs#L333

warning: useless use of `vec!` --> narwhal/node/src/generate_format.rs:146:1 | 146 | / arg_enum! { 147 | | #[derive(Debug, StructOpt, Clone, Copy)] 148 | | enum Action { 149 | | Print, ... | 152 | | } 153 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default = note: this warning originates in the macro `arg_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

unneeded sub `cfg` when there is only one condition: narwhal/primary/src/primary.rs#L69

warning: unneeded sub `cfg` when there is only one condition --> narwhal/primary/src/primary.rs:69:7 | 69 | #[cfg(any(test))] | ^^^^^^^^^ help: try: `test` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg = note: `#[warn(clippy::non_minimal_cfg)]` on by default

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> narwhal/test-utils/src/lib.rs:253:9 | 253 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

warning: sub-expression diverges --> narwhal/test-utils/src/lib.rs:246:9 | 246 | unimplemented!() | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

sub-expression diverges: /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/macros/mod.rs#L705

usage of an `Arc` that is not `Send` or `Sync`: narwhal/test-utils/src/cluster.rs#L567

warning: usage of an `Arc` that is not `Send` or `Sync` --> narwhal/test-utils/src/cluster.rs:567:23 | 567 | internal: Arc::new(RwLock::new(internal)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: the trait `Send` is not implemented for `RwLock<AuthorityDetailsInternal>` = note: the trait `Sync` is not implemented for `RwLock<AuthorityDetailsInternal>` = note: required for `Arc<RwLock<AuthorityDetailsInternal>>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

use of `default` to create a unit struct: narwhal/test-utils/src/cluster.rs#L469

warning: use of `default` to create a unit struct --> narwhal/test-utils/src/cluster.rs:469:44 | 469 | TrivialTransactionValidator::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

usage of an `Arc` that is not `Send` or `Sync`: narwhal/test-utils/src/cluster.rs#L567

use of `default` to create a unit struct: narwhal/test-utils/src/cluster.rs#L469

use of `default` to create a unit struct: narwhal/node/src/main.rs#L322

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/./unit_tests/utils.rs#L131

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/./unit_tests/utils.rs:131:9 | 131 | [ExecutionDigests::random()].into_iter(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[ExecutionDigests::random()]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> crates/sui-types/src/messages_checkpoint.rs:334:12 | 334 | T: IntoIterator<Item = ExecutionDigests>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/./unit_tests/utils.rs#L131

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig_legacy.rs#L302

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/multisig_legacy.rs:302:41 | 302 | pk_map: pks.into_iter().zip(weights.into_iter()).collect(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `weights` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig.rs#L359

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/multisig.rs:359:41 | 359 | pk_map: pks.into_iter().zip(weights.into_iter()).collect(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `weights` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig_legacy.rs#L302

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig.rs#L359

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig_legacy.rs#L302

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L717

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/messages_checkpoint.rs:717:21 | 717 | [ExecutionDigests::random()].into_iter(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[ExecutionDigests::random()]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> crates/sui-types/src/messages_checkpoint.rs:334:12 | 334 | T: IntoIterator<Item = ExecutionDigests>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L680

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/messages_checkpoint.rs:680:13 | 680 | [ExecutionDigests::random()].into_iter(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[ExecutionDigests::random()]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> crates/sui-types/src/messages_checkpoint.rs:334:12 | 334 | T: IntoIterator<Item = ExecutionDigests>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L635

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/messages_checkpoint.rs:635:13 | 635 | [ExecutionDigests::random()].into_iter(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[ExecutionDigests::random()]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> crates/sui-types/src/messages_checkpoint.rs:334:12 | 334 | T: IntoIterator<Item = ExecutionDigests>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L550

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/messages_checkpoint.rs:550:72 | 550 | FullCheckpointContents::new_with_causally_ordered_transactions(vec![exe_data].into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![exe_data]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> crates/sui-types/src/messages_checkpoint.rs:437:12 | 437 | T: IntoIterator<Item = ExecutionData>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/multisig.rs#L359

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L386

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/sui-types/src/messages_checkpoint.rs:386:38 | 386 | transactions.into_iter().zip(user_signatures.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `user_signatures` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L550

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L386

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L550

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/sui-types/src/messages_checkpoint.rs#L386

unneeded sub `cfg` when there is only one condition: narwhal/primary/src/primary.rs#L69

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1905

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1905:36 | 1905 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1859

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1859:36 | 1859 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1805

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1805:36 | 1805 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1779

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1779:36 | 1779 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1709

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1709:36 | 1709 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1679

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1679:36 | 1679 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1646

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1646:36 | 1646 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1613

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1613:36 | 1613 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1193

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:1193:36 | 1193 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L875

warning: use of `default` to create a unit struct --> crates/typed-store/src/rocks/mod.rs:875:36 | 875 | Some(RocksDBPerfContext::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1905

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1859

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1805

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1779

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1709

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1679

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1646

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1613

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1905

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1859

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1193

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1805

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1779

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L875

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1709

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1679

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1646

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1613

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1905

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1859

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1805

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1779

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1193

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1709

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1679

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L875

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1646

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1613

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L1193

use of `default` to create a unit struct: crates/typed-store/src/rocks/mod.rs#L875

usage of `Iterator::fold` on a type that implements `Try`: narwhal/config/src/committee.rs#L412

useless use of `vec!`: sui-execution/cut/src/plan.rs#L1217

warning: useless use of `vec!` --> sui-execution/cut/src/plan.rs:1217:13 | 1217 | vec![r#"[package]"#, r#"name = "quy""#].join("\n"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r#"[package]"#, r#"name = "quy""#]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

useless use of `vec!`: sui-execution/cut/src/plan.rs#L1201

warning: useless use of `vec!` --> sui-execution/cut/src/plan.rs:1201:13 | 1201 | / vec![ 1202 | | r#"[package]"#, 1203 | | r#"name = "qux""#, 1204 | | r#""#, ... | 1209 | | r#"foo = { path = "../foo", package = "foo-latest" }"#, 1210 | | ] | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 1201 ~ [r#"[package]"#, 1202 + r#"name = "qux""#, 1203 + r#""#, 1204 + r#"[target.'cfg(unix)'.dependencies]"#, 1205 + r#"bar = { path = "../bar" }"#, 1206 + r#""#, 1207 + r#"[target.'cfg(target_arch = "x86_64")'.build-dependencies]"#, 1208 + r#"foo = { path = "../foo", package = "foo-latest" }"#] |

useless use of `vec!`: sui-execution/cut/src/plan.rs#L1185

warning: useless use of `vec!` --> sui-execution/cut/src/plan.rs:1185:13 | 1185 | / vec![ 1186 | | r#"[package]"#, 1187 | | r#"name = "baz""#, 1188 | | r#""#, ... | 1193 | | r#"bar = { path = "../bar" }"#, 1194 | | ] | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 1185 ~ [r#"[package]"#, 1186 + r#"name = "baz""#, 1187 + r#""#, 1188 + r#"[dependencies]"#, 1189 + r#"acme = "1.0.0""#, 1190 + r#""#, 1191 + r#"[build-dependencies]"#, 1192 + r#"bar = { path = "../bar" }"#] |

useless use of `vec!`: sui-execution/cut/src/plan.rs#L1168

warning: useless use of `vec!` --> sui-execution/cut/src/plan.rs:1168:13 | 1168 | / vec![ 1169 | | r#"[package]"#, 1170 | | r#"name = "bar""#, 1171 | | r#""#, ... | 1177 | | r#"quy = { path = "../quy" }"#, 1178 | | ] | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 1168 ~ [r#"[package]"#, 1169 + r#"name = "bar""#, 1170 + r#""#, 1171 + r#"[dependencies]"#, 1172 + r#"foo = { path = "../foo", package = "foo-latest" }"#, 1173 + r#""#, 1174 + r#"[dev-dependencies]"#, 1175 + r#"baz = { path = "../baz" }"#, 1176 + r#"quy = { path = "../quy" }"#] |

useless use of `vec!`: sui-execution/cut/src/plan.rs#L1148

warning: useless use of `vec!` --> sui-execution/cut/src/plan.rs:1148:13 | 1148 | / vec![ 1149 | | r#"[workspace]"#, 1150 | | r#"members = ["crates/foo"]"#, 1151 | | r#"exclude = ["#, ... | 1154 | | r#"]"#, 1155 | | ] | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default help: you can use an array directly | 1148 ~ [r#"[workspace]"#, 1149 + r#"members = ["crates/foo"]"#, 1150 + r#"exclude = ["#, 1151 + r#" "crates/bar","#, 1152 + r#" "crates/qux","#, 1153 + r#"]"#] |

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/mysten-metrics/src/histogram.rs#L112

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/mysten-metrics/src/histogram.rs:112:59 | 112 | let labels: Vec<_> = labels.iter().cloned().chain(["pct"].into_iter()).collect(); | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `["pct"]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:522:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: crates/mysten-metrics/src/histogram.rs#L112

private item shadows public glob re-export: external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs#L5

warning: private item shadows public glob re-export --> external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs:5:5 | 5 | use crate::sandbox::utils::on_disk_state_view::OnDiskStateView; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the name `OnDiskStateView` in the type namespace is supposed to be publicly re-exported here --> external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs:45:9 | 45 | pub use on_disk_state_view::*; | ^^^^^^^^^^^^^^^^^^^^^ note: but the private item here shadows it --> external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs:5:5 | 5 | use crate::sandbox::utils::on_disk_state_view::OnDiskStateView; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(hidden_glob_reexports)]` on by default

private item shadows public glob re-export: external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs#L5

variable does not need to be mutable: external-crates/move/move-prover/bytecode/src/verification_analysis_v2.rs#L741

warning: variable does not need to be mutable --> external-crates/move/move-prover/bytecode/src/verification_analysis_v2.rs:741:13 | 741 | let mut info = targets | ----^^^^ | | | help: remove this `mut`

variable does not need to be mutable: external-crates/move/move-prover/bytecode/src/verification_analysis.rs#L374

warning: variable does not need to be mutable --> external-crates/move/move-prover/bytecode/src/verification_analysis.rs:374:13 | 374 | let mut info = data | ----^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

private item shadows public glob re-export: external-crates/move/tools/move-cli/src/sandbox/utils/mod.rs#L5