Fix/remove wit support #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MystenLabs#18323) ## Description Explained in comments. This unblocks the transactional tests using advance epoch, which would panic today as it would lose the randomness beacon override. ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Remove code related to resources from the transaction data cache to simplify code on our way to session removal and trait simplification in the Move VM. One step at the time to avoid making a massive and too confusing PR. This way we get more clarity on what is needed. It slightly cleans up things in the adapter as well ## Test plan Existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
…tenLabs#18301) ## Description This fixes a minor compiler implementation issue reported in MystenLabs#18285 (the `parse_file` function no longer needs to return `Result` as diagnostics previously returned as part of it are instead added to the compilation context). ## Test plan All existing tests must pass
## Description Refactor the DKG to allow protocol upgrades of the cryptographic protocol, and migrate to V1 (controlled by a protocol config parameter). ## Test plan Existing tests and the "Continuous" GH workflow. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: - [x] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
The random tests will print out a seed that can be passed in as an env var (`DAG_TEST_SEED`) to repro any failures. Also for now going through block manager so we can randomize how the blocks are received but ideally we can test this flow directly through core once "turning off proposal" is possible in core. Additionally we can follow up this PR with even more randomized dags to simulate crashes, byzantine validators, etc.
## Description - Added advance epoch support to normal sui-adapter-transactional-tests ## Test plan - added a test --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Support building image from suiop CLI With this, you can build and push images to our repo. The CLI tool supports building from branch, commit or tag. ## Test plan you can build from branch or commit from suiop CLI <img width="1456" alt="image" src="https://github.com/MystenLabs/sui/assets/147538877/fc4b887e-a4e0-4a5a-bdbc-3099202e155b"> you can also query the image build history: <img width="1090" alt="image" src="https://github.com/MystenLabs/sui/assets/147538877/e0bd0847-0a8a-46a7-a264-c68bbcfaa7b1"> --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: jk jensen <jk@mystenlabs.com>
## Description syncing antithesis changes to their docker compose env Co-authored-by: xavsan <113532407+xavsan@users.noreply.github.com>
## Description The main fix here is to add back merge of `file_use_defs` in the `Symbols` struct accidentally removed in MystenLabs#18270 It also finesses merging of `MappedFiles` struct a bit: - re-implements a variant of `extend` function that allows duplicate hashes (as this is a normal situation when merging symbolic information (as most files will not change between symbol computations) - adds `MappedFiles` extension on pre-compiled libs retrieval (as opposed to having it only on pre-compiled lib computation) ## Test plan All tests must pass plus verified that IDE support now again works correctly
…re approved. (MystenLabs#18262) ## Description as title ## Test plan unit test. Will add an e2e test in a separate PR (needs some new test infra that will inflate this PR) --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
…s#18333) ## Description Verify that DKG completes after the reconf in split-cluster-check. Also add a more concrete log for 'DKG start' event, to be used in the future in the above verification. ## Test plan manually tested --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description @chris-gorham pointed out a copy-paste error on my end
## Description Added the following: - DepositedUnfinalized TokenTransferStatus. This status indicates that this event was captured in an unfinalized block. - LatestEthSyncer component that enables the indexer to listen to unfinalized blocks. - Eth idempotency. This is so that we can start indexing from the block that was last processed when starting / restarting the indexer.
…#18289) ## Description Store sui checkpoint ingression progress in db instead of files ## Test plan deployed and tested on testnet --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Little PR that adds support for using named addresses in Move IR source syntax. ## Test plan Added a test to make sure that we handle them correctly, and existing tests.
## Description Fix a bug where mutability was preserved for variables when creating match bindings (not the final arm binders, but the imm. ref binders themselves). ## Test plan Test added that demonstrated the issue, and now it works instead. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Refactor eth_worker to clean up main. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description - Added additional functionality for config types - Moved them to their own module ## Test plan - 👀 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Sui v1.28.0 Framework snapshot ## Test plan 👀
## Description We don't find this event super useful yet. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description We want to disable bridging of zero amounts provided. ## Test plan Added two unit tests for both ERC20 and Native ETH bridging --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Sui v1.29.0 version bump ## Test plan 👀
## Description This swaps the move analyzer `DefLoc` to be a shared IR `Loc` form (used everywhere else). ## Test plan The move analyzer tests pass, plus local testing in VS Code still works. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Says by the title. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description avoid forcing putting the db url in a config file, optionally read it via env var ## Test plan Will test before shipping --------- Co-authored-by: longbowlu <zl9394@gmail.com>
…enLabs#17934) ## Description Adds the following attribute to `sui_graphql_rpc::types::object::Object`: ```rust /// Optional root parent object version if this is a dynamic field. /// /// This enables consistent dynamic field reads in the case of chained dynamic object fields, /// e.g., `Parent -> DOF1 -> DOF2`. In such cases, the object versions may end up like /// `Parent >= DOF1, DOF2` but `DOF1 < DOF2`. Thus, database queries for dynamic fields must /// bound the object versions by the version of the root object of the tree. /// /// Essentially, lamport timestamps of objects are updated for all top-level mutable objects /// provided as inputs to a transaction as well as any mutated dynamic child objects. However, /// any dynamic child objects that were loaded but not actually mutated don't end up having /// their versions updated. root_version: Option<u64>, ``` I tried making sure that this attribute is set correctly wherever an `Object` is created. There's one scenario which still isn't covered: if the GQL query is rooted at a DOF, something like ```graphql query DynamicFields($parent: SuiAddress!, $version: Int, $after: String) { object(address: $parent, version: $version) { dynamicFields(/* ... */) { // ... } } } ``` where `$parent` is a DOF's object id, then the server has no way to know the root object's version. Instead, we will use the rooting object's version, even if it is a nested child object. ## Test plan New tests `immutable_dof.move` and `nested_dof.move`. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ashok Menon <amenon94@gmail.com> Co-authored-by: Will Yang <willyang@mystenlabs.com>
## Description
Describe the changes or additions included in this PR.
## Test plan
```
eugene@eugene-dev ~/code/sui (remove-whitespace) $ ./scripts/compatibility/check-protocol-compatibility.sh testnet
Found following versions on testnet:
86 1.28.3-3781a7e6b56c
9 1.28.2-08b50387a184
2 1.28.3-3781a7e6b5
1 1.28.3-3781a7e6b56c-dirty
Using most frequent version 1.28.3-3781a7e6b56c for compatibility check
Source commit: 68e59b5
Source branch: remove-whitespace
Checking protocol compatibility with testnet (3781a7e)
Checking out testnet snapshot files
Checking for changes to snapshot files matching *__Testnet_version_*
HEAD is now at 68e59b5 remove whitespace
Running snapshot tests...
Updating crates.io index
Compiling serde_json v1.0.120
Compiling serde_derive_internals v0.29.1
Compiling move-core-types v0.0.4 (/home/eugene/code/sui/external-crates/move/crates/move-core-types)
Compiling schemars_derive v0.8.21
Compiling move-binary-format v0.0.3 (/home/eugene/code/sui/external-crates/move/crates/move-binary-format)
Compiling move-vm-config v0.1.0 (/home/eugene/code/sui/external-crates/move/crates/move-vm-config)
Compiling schemars v0.8.21
Compiling sui-protocol-config v0.1.0 (/home/eugene/code/sui/crates/sui-protocol-config)
Finished test [unoptimized + debuginfo] target(s) in 4.39s
Running unittests src/lib.rs (target/debug/deps/sui_protocol_config-293e7e5c732ea482)
running 1 test
test test::snapshot_tests ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 4 filtered out; finished in 0.39s
```
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
MystenLabs#18603) ## Description There is room for precision error here given the nature of this code, so let's make use of it to fix flakiness. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Adds additional tests for enums in Sui. ## Test plan It's all tests!
Incorrect environment is specified as the default--the default env installed if you hit 'enter' is Testnet, not Devnet. This is according to my own Sui installation on WSL/Ubuntu, and is also described as "Testnet" in the code snippet immediately above the change. ## Description Change "Devnet" to "Testnet" ## Test plan How did you test the new or updated feature? see screenshot for proof that the default is Testnet, not Devnet. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: <img width="1014" alt="image" src="https://github.com/MystenLabs/sui/assets/38071276/807347d2-9821-46f0-aab6-0b41f1362e28">
## Description Port Move code for the tic tac toe example into the `sui/examples` directory, modernising it in the process: - Standardise the implementation between the owned, shared and multi-sig variants, so that the only differences are relevant to what they need to do differently. In doing this, the owned and multi-sig variants become identical (at least at the level of Move code). - Use transfer-to-object in the "owned" example, to send potential moves to the `Game` object, instead of the admin that owns the game. - Use more Move 2024 features (`syntax(index)`, receiver function aliases, etc). - Improve test coverage ## Test plan New unit tests: ``` tic_tac_toe/move$ sui move test ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Build front-ends for shared and multi-sig tic-tac-toe, using `create-react-dapp`. ## Test plan Manually tested (screenshots below). #### New Shared game  #### New MultiSig game  #### Game in-progress  #### Game won, viewed by player  #### Game won, viewed by spectator (no wallet connected)  #### Delete game dialog  ## Stack - MystenLabs#18525
…enLabs#18592) ## Description Nodes taking proxied connections can provide configuration that allows traffic controller to read the `x-forwarded-for` header so that we tally against the client rather than the proxy. Unfortunately we only supported this in code for authority server. This PR fixes that ## Test plan Existing tests. Will later test against an rpc node behind a proxy. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
…8618) ## Description During rocksdb snapshotting of the db (for creating rocksdb checkpoints), we temporarily suffix the toplevel dir with `.tmp`, and remove it after the snapshotting is complete. There is cleanup code to ensure that these temp files get deleted if we were to crash mid-operation, however there may be some rare edge cases where this is not the case, for example if we crash mid-operation, then start the node up again without db checkpointing enabled, causing the node to progress to the next epoch never having executed the cleanup code. In such cases, we will panic on all subsequent snapshot upload attempts due to inability to parse the db checkpoint name due to the unexpected `.tmp` suffix. This handles that edge case by ignoring such files. ## Test plan 👀 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Fix faucet for when requesting local coins as it returns created status code ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
… mysticeti mainnet (MystenLabs#18564) ## Description Enable features in protocol config (v52) for Mysticeti mainnet launch - Checkpoint batching - Leader Scoring & Schedule Change --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ X ] Protocol: v52 -- Enable checkpoint batching in mainnet. -- Enable Leader Scoring & Schedule Change for Mysticeti consensus on mainnet.
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description - Charge for gas based on the number of config objects loaded (estimated worst case) ## Test plan - Added new tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description
Write a CLI to talk to the shared and multi-sig tic-tac-toe example
Move packages.
## Test plan
Manual testing:
```
$ tic-tac-toe view 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed
X | O |
---+---+---
O | X |
---+---+---
| | X
X: <address>
-> O: <address>
GAME: 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed
ADMIN: <public key>
X WINS!
```
Also, confirmed that the CLI works with the React front-end.
## Stack
- MystenLabs#18525
- MystenLabs#18526
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
## Description Enable verbose mode for cargo llvm-cov ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
## Description Sui v1.29.0 Bytecode Framework snapshot ## Test plan 👀
…ystenLabs#18712) ## Description Always pick whole UTF8 characters. ## Test plan Tested against a package containing a UTF8 constant. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [x] Nodes (Validators and Full nodes): Bugfix for fetching package information over JSONRPC from fullnodes, where a package containing UTF8 string constants could fail to disassemble. - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Signed-off-by: Carlos Baez <cb@mamoru.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.