warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:352:9
    |
352 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:345:9
    |
345 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:338:9
    |
338 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:331:9
    |
331 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:324:9
    |
324 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:317:9
    |
317 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:289:9
    |
289 |         unimplemented!();
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:282:9
    |
282 |         unimplemented!();
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:246:9
    |
246 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:238:9
    |
238 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-core/src/test_authority_clients.rs:230:9
    |
230 |         unimplemented!();
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> crates/sui-core/src/transaction_manager.rs:503:18
    |
503 |             .zip(input_object_cache_misses.into_iter());
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `input_object_cache_misses`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct
   --> crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs:203:44
    |
203 |                 TrivialTransactionValidator::default(),
    |                                            ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
   --> crates/sui-core/src/narwhal_manager/../unit_tests/narwhal_manager_tests.rs:141:44
    |
141 |                 TrivialTransactionValidator::default(),
    |                                            ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

warning: sub-expression diverges
   --> crates/sui-core/src/unit_tests/consensus_tests.rs:201:9
    |
201 |         unimplemented!()
    |         ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: `#[warn(clippy::diverging_sub_expression)]` on by default
    = note: this warning originates in the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
    --> crates/sui-core/src/checkpoints/mod.rs:1146:22
     |
1146 |                 .zip(pending.into_iter())
     |                      ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `pending`
     |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
    --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs:957:18
    |
957 |             .zip(expected_effects_digests.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `expected_effects_digests`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs:939:18
    |
939 |             .zip(expected_effects_digests.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `expected_effects_digests`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: redundant pattern matching, consider using `is_none()`
   --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:294:13
    |
294 |       assert!(matches!(
    |  _____________^
295 | |         checkpoint_store
296 | |             .get_highest_executed_checkpoint_seq_number()
297 | |             .unwrap(),
298 | |         None,
299 | |     ));
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
help: try this
    |
294 ~     assert!(checkpoint_store
295 +             .get_highest_executed_checkpoint_seq_number()
296 ~             .unwrap().is_none());
    |

warning: redundant pattern matching, consider using `is_none()`
   --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:130:13
    |
130 |       assert!(matches!(
    |  _____________^
131 | |         checkpoint_store
132 | |             .get_highest_executed_checkpoint_seq_number()
133 | |             .unwrap(),
134 | |         None,
135 | |     ));
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
help: try this
    |
130 ~     assert!(checkpoint_store
131 +             .get_highest_executed_checkpoint_seq_number()
132 ~             .unwrap().is_none());
    |

warning: redundant pattern matching, consider using `is_none()`
  --> crates/sui-core/src/checkpoints/checkpoint_executor/tests.rs:41:13
   |
41 |       assert!(matches!(
   |  _____________^
42 | |         checkpoint_store
43 | |             .get_highest_executed_checkpoint_seq_number()
44 | |             .unwrap(),
45 | |         None,
46 | |     ));
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
   = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
help: try this
   |
41 ~     assert!(checkpoint_store
42 +             .get_highest_executed_checkpoint_seq_number()
43 ~             .unwrap().is_none());
   |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
    --> crates/sui-core/src/authority_aggregator.rs:1771:33
     |
1771 |                         .extend(fastpath_input_objects.into_iter());
     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `fastpath_input_objects`
     |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
    --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: sub-expression diverges
   --> crates/sui-cluster-test/src/cluster.rs:282:9
    |
282 | /         unreachable!(
283 | |             "If we already have a boxed Cluster trait object we wouldn't have to call this function"
284 | |         );
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: `#[warn(clippy::diverging_sub_expression)]` on by default
    = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unreachable` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: sub-expression diverges
   --> crates/sui-cluster-test/src/cluster.rs:282:9
    |
282 | /         unreachable!(
283 | |             "If we already have a boxed Cluster trait object we wouldn't have to call this function"
284 | |         );
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: `#[warn(clippy::diverging_sub_expression)]` on by default
    = note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unreachable` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> crates/sui-core/src/authority/authority_notify_read.rs:103:18
    |
103 |             .zip(registrations.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `registrations`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion