Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify open_timeout #163

Closed
grosser opened this issue Apr 26, 2016 · 9 comments
Closed

modify open_timeout #163

grosser opened this issue Apr 26, 2016 · 9 comments

Comments

@grosser
Copy link
Contributor

grosser commented Apr 26, 2016

I want to pass in open_timeout and read_timeout since they both seem to be too big by default,
but passing them in results in ArgumentError - unknown keyword: open_timeout:

any idea @msufa @abonas ?

@abonas
Copy link
Member

abonas commented Apr 27, 2016

@grosser could you please provide a specific code example with how you are trying to do this?
thanks!

@grosser
Copy link
Contributor Author

grosser commented Apr 27, 2016

Kubeclient::Client.new(url, 'v1', open_timeout: 2)

@abonas
Copy link
Member

abonas commented Apr 27, 2016

if I understand correctly the issue here - you are trying to pass a parameter that is not recognized/ supported by kubeclient itself at the moment, (did you see somewhere documentation of kubeclient usage with this parameter?) , so it makes sense that it doesn't work at the moment.
cc @simon3z

@grosser
Copy link
Contributor Author

grosser commented Apr 27, 2016

I saw that I cannot pass it in ... that's why I opened an issue :)

On Tue, Apr 26, 2016 at 10:33 PM, abonas notifications@github.com wrote:

if I understand correctly the issue here - you are trying to pass a
parameter that is not recognized/ supported by kubeclient itself at the
moment, (did you see somewhere documentation of kubeclient usage with this
parameter?) , so it makes sense that it doesn't work at the moment.
cc @simon3z https://github.com/simon3z


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#163 (comment)

@abonas
Copy link
Member

abonas commented Apr 27, 2016

@grosser it was not clear from your issue that this is a feature request, but rather it sounded like reporting a bug.

@grosser
Copy link
Contributor Author

grosser commented Apr 27, 2016

ah sorry, definitely a feature request :)
(read_timeout would also be nice while we are at it ... or just all http options ...)

@abonas
Copy link
Member

abonas commented Apr 27, 2016

@grosser I don't think I'll have the time to get this implemented in the near future, but perhaps some other community member can pick up the glove.

@simon3z
Copy link
Collaborator

simon3z commented Apr 27, 2016

I am ok to add these timeouts, but remember that watches are special:

https://github.com/abonas/kubeclient/pull/24/files

In the past I had to force the read_timeout to nil in that case to prevent the connection to be dropped for inactivity.

@cben
Copy link
Collaborator

cben commented Mar 4, 2018

Done in #244 (on master & 2.4.0 via #246).

@cben cben closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants