Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.x] Add requests timeouts option #246

Merged
merged 3 commits into from
Apr 30, 2017
Merged

[v2.x] Add requests timeouts option #246

merged 3 commits into from
Apr 30, 2017

Commits on Apr 28, 2017

  1. Test both rest-client 1.8 and latest 

    Until we can require 2.0 - next major release?

In theory our gemspec lets you combine any ancient
rest-client with kubeclient but not really,
our tests fail on 1.7.
    @cben @simon3z
    cben authored and simon3z committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    cecf873 View commit details
    Browse the repository at this point in the history

  2. ParameterLists rubocop: don't penalize keyword args

    @cben @simon3z
    cben authored and simon3z committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    991871e View commit details
    Browse the repository at this point in the history

  3. Add timeouts option 

    Doesn't affect watch, only rest-client based functionality.

Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
    @cben @simon3z
    cben authored and simon3z committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    539591f View commit details
    Browse the repository at this point in the history