Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundler version failure with ruby 2.7 #631

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 2, 2024

The kubeclient actions.yml was manually installing rake and bundler overriding what ruby/setup-ruby was installing. This would attempt to install the latest version of bundler which is not supported on ruby 2.7 so the gem install was failing [ref]

Run gem install rake bundler
ERROR:  Error installing bundler:
	The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225.
Successfully installed rake-13.2.0
1 gem installed
Error: Process completed with exit code 1.

ruby/setup-ruby will install the correct bundler for the version of ruby requested.

@agrare agrare force-pushed the fix_bundler_version_failure_ruby_2_7 branch from 4824b69 to afb8a21 Compare April 2, 2024 14:46
@agrare
Copy link
Member Author

agrare commented Apr 2, 2024

NOTE there are some legitimate test failures on master so this PR will be red, but all specs should run where before the 2.7 runs would fail to start

@agrare
Copy link
Member Author

agrare commented Apr 2, 2024

Test failures fixed by #632

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @agrare to merge on red.

@Fryguy Fryguy merged commit 07de294 into ManageIQ:master Apr 2, 2024
16 of 26 checks passed
@agrare agrare deleted the fix_bundler_version_failure_ruby_2_7 branch April 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants