-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy resolution call to vm_destroy for providers. #223
Conversation
@lfu Are there other provider events that this policy event should be tied to? |
Removing a virtual machine in RHEV is final and cannot be reversed. https://bugzilla.redhat.com/show_bug.cgi?id=1506520
8d1413e
to
a0b9857
Compare
@lfu RHV has the option as well but as far as I know VMware is the only one with a different API call to do this |
/cc @pkliczewski |
Looks good, verified for ovirt. |
Checked commits lfu/manageiq-content@2c56415~...a0b9857 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
Add policy resolution call to vm_destroy for providers. (cherry picked from commit 78dcaa8) https://bugzilla.redhat.com/show_bug.cgi?id=1533279
Gaprindashvili backport details:
|
Add policy resolution call to vm_destroy for providers. (cherry picked from commit 78dcaa8) https://bugzilla.redhat.com/show_bug.cgi?id=1534584
Fine backport details:
|
vm_destroy is the policy event raised when a VM is deleted from disk from VMware side.
vm_unregister is the policy event raised when a VM is removed from inventory from VMware side.
Add vm_destroy call for all providers.
Seems VMware is the only one which has the option to remove VM from inventory besides delete VM from disk. @agrare @bronaghs, is it right?
Part of ManageIQ/manageiq#16557.
https://bugzilla.redhat.com/show_bug.cgi?id=1506520
@miq-bot add_label bug, fine/yes, gaprindashvili/yes