Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sed line Mac compatible #1151

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Aug 15, 2024

@bdunne Please review

cc @kbrock - this is what was causing your make manifests to have a git diff.

@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2024

Checked commit Fryguy@042e41e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit 794a248 into ManageIQ:master Aug 15, 2024
2 checks passed
@Fryguy Fryguy deleted the fix_mac_compat branch August 15, 2024 20:34
@Fryguy
Copy link
Member Author

Fryguy commented Aug 22, 2024

Backported to radjabov in commit 7819398.

commit 7819398a0471a76f39688904558fc0b1011e537a
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Thu Aug 15 16:27:23 2024 -0400

    Merge pull request #1151 from Fryguy/fix_mac_compat
    
    Make the sed line Mac compatible
    
    (cherry picked from commit 794a2488940eb7848ed08448a769bafc7f17b6dd)

Fryguy pushed a commit that referenced this pull request Aug 22, 2024
Make the sed line Mac compatible

(cherry picked from commit 794a248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants