Tests cloud_networks with RBAC filtering from super #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label test |
|
@syncrou can you review please? |
|
@Ladas does this work for ManageIQ/manageiq#16824 (comment)? |
d-m-u
changed the title
|
@d-m-u Once you rebase, the tests should pass. |
d-m-u
force-pushed
the
adding_test_for_allowed_ci
branch
from
c224366
to
27ba999
Compare
bronaghs
reviewed
Feb 22, 2018
| allow(User).to receive_messages(:server_timezone => "UTC") | ||
| FactoryGirl.create(:ems_amazon) | ||
| end | ||
|
|
There was a problem hiding this comment.
@d-m-u - can you use:ems instead of creating :provider?
d-m-u
force-pushed
the
adding_test_for_allowed_ci
branch
from
27ba999
to
64ad835
Compare
|
Checked commit d-m-u@64ad835 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gmcculloug - bump |
gmcculloug
approved these changes
Mar 9, 2018
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 22, 2018
Tests cloud_networks with RBAC filtering from super (cherry picked from commit 6f051ff)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon's allowed_cloud_networks needs test for RBAC filtering from PR here