Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to check that cloud network list is dependent on zone #199

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jan 17, 2018

PR ManageIQ/manageiq#16811 adds RBAC filtering to allowed_cloud_network base class and azure needed specs around the fact that the cloud network list is dependent on availability zone choice. (Per ManageIQ/manageiq#16824 (comment))

Related bz links:
https://bugzilla.redhat.com/show_bug.cgi?id=1533277
https://bugzilla.redhat.com/show_bug.cgi?id=1535189

@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 17, 2018

@miq-bot add_label test

@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 17, 2018

@miq-bot assign @gmcculloug
(I'm not sure who else to assign, sorry!)

@d-m-u d-m-u force-pushed the adding_tests_to_cloud_networks branch from e3943ea to 3f3ee5b Compare January 17, 2018 15:29
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2018

Checked commit d-m-u@3f3ee5b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 19, 2018

@miq-bot unassign @gmcculloug
@miq-bot assign @bronaghs

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

@d-m-u unrecognized command 'unassign', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot miq-bot assigned bronaghs and unassigned gmcculloug Jan 19, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 19, 2018

@miq-bot bite_me

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

@d-m-u unrecognized command 'bite_me', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@bronaghs
Copy link

@gmcculloug - Can you review? I know this is tied to a number of other PRs.

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2018

@d-m-u unrecognized command 'unassign', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot miq-bot assigned gmcculloug and bronaghs and unassigned bronaghs and gmcculloug Jan 26, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2018

@d-m-u unrecognized command 'bite_me', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@bronaghs bronaghs merged commit 386b14d into ManageIQ:master Feb 6, 2018
@bronaghs bronaghs added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 6, 2018
@d-m-u d-m-u deleted the adding_tests_to_cloud_networks branch February 6, 2018 16:10
@d-m-u
Copy link
Contributor Author

d-m-u commented Mar 20, 2018

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 22, 2018
Add tests to check that cloud network list is dependent on zone
(cherry picked from commit 386b14d)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 32d54d5907913b662e006da99c03b01fe9f8a2df
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Tue Feb 6 10:08:05 2018 -0500

    Merge pull request #199 from d-m-u/adding_tests_to_cloud_networks
    
    Add tests to check that cloud network list is dependent on zone
    (cherry picked from commit 386b14d7b48f932af198e3add1094701854c4051)

@simaishi
Copy link
Contributor

simaishi commented Apr 2, 2018

@d-m-u Can you please take a look at Travis failure in Gaprindashvili branch?
https://travis-ci.org/ManageIQ/manageiq-providers-azure/builds/359118535

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2018

@simaishi sorry! #207 needs to be backported too, am updating with labels in just a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants