Add EmbeddedTerraform UI #3

agrare · 2024-03-04T19:35:37Z

Depends on:

Pluggable credential types manageiq#22995
Add embedded terraform UI changes manageiq-ui-classic#9117 (we'll have to manually run with this other PR while developing this on master of this provider)

Depend
TODO

Menu:

Credentials Show List:

Credentials Show:

Credentials Show -> Repositories Show List:

Repositories Show List:

Repositories Show:

Repositories Show -> Templates Show List:

Templates Show List:

Templates Show:

GilbertCherrie · 2024-03-13T19:01:32Z

This pr depends on UI PR: ManageIQ/manageiq-ui-classic#9117 and core PR: ManageIQ/manageiq#22943

jrafanie · 2024-03-28T18:20:59Z

Note, #9 has been merged, renaming ConfigurationScriptPayload to Template

app/controllers/embedded_terraform_repository_controller.rb

jrafanie · 2024-03-28T18:23:43Z

app/controllers/embedded_terraform_workflow_controller.rb

+  menu_section :embedded_terraform_workflow
+
+  def self.model
+    ManageIQ::Providers::EmbeddedTerraform::AutomationManager::ConfigurationScriptPayload


Suggested change

ManageIQ::Providers::EmbeddedTerraform::AutomationManager::ConfigurationScriptPayload

ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Template

locale/en.yml

...views/ManageIQ_Providers_EmbeddedTerraform_AutomationManager_ConfigurationScriptPayload.yaml

agrare · 2024-03-28T19:22:17Z

Okay it was pretty involved to rename this but I think I got everything done and tested

app/views/embedded_terraform_template/show.html.haml

agrare · 2024-03-28T19:49:32Z

I'm going to take this out of WIP, I've tested creating SCM credentials, creating a repository, and viewing imported templates on the UI and everything appears functional.

jrafanie · 2024-03-29T15:26:54Z

app/controllers/embedded_terraform_credential_controller.rb

+    when 'ansible_credential_tag'
+      tag(self.class.model)
+    when "ansible_repository_tag" # repositories from nested list
+      tag(ManageIQ::Providers::EmbeddedTerraform::AutomationManager::ConfigurationScriptSource)


Do each of these cases automatically do assert_privileges checks from tag, javascript_redirect, etc.?

🤣 I think they do... looking down below.

not sure about tag but maybe

should it say ansible_credential_tag and ansible_resository_tag?

app/controllers/embedded_terraform_credential_controller.rb

app/controllers/embedded_terraform_repository_controller.rb

jrafanie · 2024-03-29T15:35:54Z

app/controllers/embedded_terraform_credential_controller.rb

+  end
+
+  def tag_edit_form_field_changed
+    assert_privileges('ansible_credential_tag')


similar to above, is it ansible or terraform?

I think we don't want to depend something which requires a database migration in order to merge this, so for now ansible_credential_tag is fine (this is the same for embedded_workflows which also uses ansible_credential_tag and we can fix them together)

jrafanie · 2024-03-29T15:36:19Z

app/controllers/embedded_terraform_repository_controller.rb

+        page << javascript_prologue
+        page.replace("main_div", :template => "embedded_terraform_repository/show")
+      end
+    when "ansible_repository_tag"


same as above re: ansible instead of terraform

jrafanie · 2024-03-29T15:36:30Z

app/helpers/application_helper/toolbar/embedded_terraform_credential_center.rb

+                   t,
+                   :items => [
+                     button(
+                       :ansible_credential_tag,


Ditto from above

jrafanie · 2024-03-29T15:36:44Z

app/helpers/application_helper/toolbar/embedded_terraform_credentials_center.rb

+                   :onwhen  => "1+",
+                   :items   => [
+                     button(
+                       :ansible_credential_tag,


jrafanie · 2024-03-29T15:37:05Z

app/helpers/application_helper/toolbar/embedded_terraform_repositories_center.rb

+                   :items   =>
+                               [
+                                 button(
+                                   :ansible_repository_tag,


more ansible product features

jrafanie · 2024-03-29T15:37:19Z

app/helpers/application_helper/toolbar/embedded_terraform_repository_center.rb

+                   :items =>
+                             [
+                               button(
+                                 :ansible_repository_tag,


last two ansible features

We started with embedded ansible but with the addition of embedded terraform, it makes sense to generalize these common product features. Related to ManageIQ/manageiq-providers-embedded_terraform#3

agrare · 2024-04-24T15:56:36Z

@jrafanie I think this is ready to merge we just wont have ManageIQ/manageiq-ui-classic#9117 until we add this plugin to the core Gemfile

jrafanie · 2024-04-24T16:07:34Z

@jrafanie I think this is ready to merge we just wont have ManageIQ/manageiq-ui-classic#9117 until we add this plugin to the core Gemfile

yes, I tried it out yesterday and it was working so let's get this in. It's in the new provider anyway so you would need to have added the provider in the first place to encounter any problems this PR may introduce.

jrafanie · 2024-04-24T16:08:15Z

@jeffibm feel free to review/comment on this after it's merged, we can always fix any problems you see. Thanks!

We started with embedded ansible but with the addition of embedded terraform, it makes sense to generalize these common product features. Related to ManageIQ/manageiq-providers-embedded_terraform#3

This comment was marked as outdated.

Sign in to view

Fryguy added the enhancement New feature or request label Mar 6, 2024

Fryguy assigned jeffibm Mar 6, 2024

This was referenced Mar 13, 2024

Add embedded terraform UI changes ManageIQ/manageiq-ui-classic#9117

Merged

Add embedded terraform core changes ManageIQ/manageiq#22943

Closed

Fryguy mentioned this pull request Mar 26, 2024

Create an Embedded Terraform provider ManageIQ/manageiq#22956

Closed

40 tasks

agrare mentioned this pull request Mar 28, 2024

Rename ConfigurationScriptPayload as Template #9

Merged

jrafanie reviewed Mar 28, 2024

View reviewed changes

app/controllers/embedded_terraform_repository_controller.rb Outdated Show resolved Hide resolved

jrafanie reviewed Mar 28, 2024

View reviewed changes

app/controllers/embedded_terraform_repository_controller.rb Outdated Show resolved Hide resolved

jrafanie reviewed Mar 28, 2024

View reviewed changes

locale/en.yml Outdated Show resolved Hide resolved

jrafanie reviewed Mar 28, 2024

View reviewed changes

...views/ManageIQ_Providers_EmbeddedTerraform_AutomationManager_ConfigurationScriptPayload.yaml Outdated Show resolved Hide resolved

agrare force-pushed the add_embedded_terraform_ui branch 2 times, most recently from d617432 to 24786f6 Compare March 28, 2024 19:21

agrare commented Mar 28, 2024

View reviewed changes

app/views/embedded_terraform_template/show.html.haml Outdated Show resolved Hide resolved

agrare and others added 8 commits March 28, 2024 15:47

Add EmbeddedTerraform UI

9fdd24c

Move menu to provider plugin

0961f48

Move routes to provider plugin

876471a

Refactor plugin routes

f0ba9b8

Update react references to use new forms

271b7f8

Add english locale file for terraform pages

7b93027

Fix link to workflows table

fcdb226

Fix credential page link to repositories table

566af32

agrare force-pushed the add_embedded_terraform_ui branch from 24786f6 to 566af32 Compare March 28, 2024 19:47

agrare changed the title ~~[WIP] Add EmbeddedTerraform UI~~ Add EmbeddedTerraform UI Mar 28, 2024

Fix toolbars for nested repositories

6b8a196

jrafanie reviewed Mar 29, 2024

View reviewed changes

app/controllers/embedded_terraform_credential_controller.rb Outdated Show resolved Hide resolved

jrafanie reviewed Mar 29, 2024

View reviewed changes

app/controllers/embedded_terraform_repository_controller.rb Outdated Show resolved Hide resolved

jrafanie reviewed Mar 29, 2024

View reviewed changes

Fix toolbar for nested templates

a0ebda0

GilbertCherrie force-pushed the add_embedded_terraform_ui branch from 048e82c to a0ebda0 Compare April 1, 2024 12:24

jrafanie mentioned this pull request Apr 1, 2024

Generalize the product feature for automation manager tagging of repos and credentials ManageIQ/manageiq#22971

Merged

6 tasks

agrare force-pushed the add_embedded_terraform_ui branch from a0ebda0 to 8ede6a6 Compare April 1, 2024 19:23

agrare force-pushed the add_embedded_terraform_ui branch from 5eb891a to 3126bea Compare April 15, 2024 16:48

nasark mentioned this pull request Apr 16, 2024

Add Embedded Terraform credential type #13

Merged

2 tasks

GilbertCherrie force-pushed the add_embedded_terraform_ui branch from 3126bea to fff7ad5 Compare April 22, 2024 14:57

Remove map credentials code

45033ef

GilbertCherrie force-pushed the add_embedded_terraform_ui branch from fff7ad5 to 45033ef Compare April 22, 2024 14:58

Remove log.warn

6ac5f6d

jrafanie mentioned this pull request Apr 23, 2024

Add cloud creds support for terraform runner #16

Merged

jrafanie assigned jrafanie and unassigned jeffibm Apr 24, 2024

jrafanie merged commit 3c41cd3 into ManageIQ:master Apr 24, 2024
3 of 4 checks passed

agrare deleted the add_embedded_terraform_ui branch April 24, 2024 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EmbeddedTerraform UI #3

Add EmbeddedTerraform UI #3

agrare commented Mar 4, 2024 •

edited by jrafanie

Loading

This comment was marked as outdated.

GilbertCherrie commented Mar 13, 2024

jrafanie commented Mar 28, 2024

jrafanie Mar 28, 2024

agrare commented Mar 28, 2024

agrare commented Mar 28, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

agrare Apr 15, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

jrafanie Mar 29, 2024

agrare commented Apr 24, 2024

jrafanie commented Apr 24, 2024

jrafanie commented Apr 24, 2024

	ManageIQ::Providers::EmbeddedTerraform::AutomationManager::ConfigurationScriptPayload
	ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Template

Add EmbeddedTerraform UI #3

Add EmbeddedTerraform UI #3

Conversation

agrare commented Mar 4, 2024 • edited by jrafanie Loading

This comment was marked as outdated.

GilbertCherrie commented Mar 13, 2024

jrafanie commented Mar 28, 2024

Choose a reason for hiding this comment

agrare commented Mar 28, 2024

agrare commented Mar 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrare commented Apr 24, 2024

jrafanie commented Apr 24, 2024

jrafanie commented Apr 24, 2024

agrare commented Mar 4, 2024 •

edited by jrafanie

Loading