Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding environment variable for offline or airgap env #62

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

sudhir-kelkar
Copy link
Contributor

This PR will help us add environment variables in opentofu deployment.
We are adding 2 environment variables here
LOG4JS_LEVEL -> This will help us update log level in case we want to do further debugging
AIRGAP_OFFLINE -> This will help terraform runner to understand if customer is running in airgap environment

@agrare
Copy link
Member

agrare commented Jul 3, 2024

Okay now in order for your worker to be restarted when the settings change you should add

self.worker_settings_paths = [
  %i[log level_embedded_terraform],
  %i[workers worker_base opentofu_worker]
]

@agrare
Copy link
Member

agrare commented Jul 3, 2024

@sudhir-kelkar can you add these environment variables to the unit_environment_variables section as well? That is what sets environment variables for the appliance systemd service.

@agrare agrare self-assigned this Jul 3, 2024
@agrare agrare added the enhancement New feature or request label Jul 3, 2024
@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2024

Checked commits sudhir-kelkar/manageiq-providers-embedded_terraform@40a5cbc~...8186235 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare merged commit 68a649b into ManageIQ:master Jul 3, 2024
4 checks passed
@Fryguy
Copy link
Member

Fryguy commented Jul 9, 2024

Backported to radjabov in commit 837ab53.

commit 837ab532e3913231c1a926fc7eb71e29d29b6a0c
Author: Adam Grare <adam@grare.com>
Date:   Wed Jul 3 14:01:04 2024 -0400

    Merge pull request #62 from sudhir-kelkar/envOfflineAirgap
    
    Adding environment variable for offline or airgap env
    
    (cherry picked from commit 68a649b5bf4849ce210d7b7d3e90847ee48f6100)

Fryguy pushed a commit that referenced this pull request Jul 9, 2024
Adding environment variable for offline or airgap env

(cherry picked from commit 68a649b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants