-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix terraform template name #66
Conversation
...dels/manageiq/providers/embedded_terraform/automation_manager/configuration_script_source.rb
Show resolved
Hide resolved
@agrare Please review. |
Note that in @GilbertCherrie 's screenshot the name of his repository is |
...dels/manageiq/providers/embedded_terraform/automation_manager/configuration_script_source.rb
Outdated
Show resolved
Hide resolved
c60f5e9
to
df6551e
Compare
df6551e
to
ae80102
Compare
Checked commit GilbertCherrie@ae80102 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
expect(names.first).to(eq("hello_world_local(master):#{local_repo}/")) | ||
expect(names.first).to(eq("/hello_world_local")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little weird that the names for non-folder-based ones have a leading slash - we should probably remove that.
Fix terraform template name.
Before:
![Screenshot 2024-07-11 at 4 45 04 PM](https://private-user-images.githubusercontent.com/32444791/347992710-f7360beb-0756-4a6b-af3c-620b06b8f252.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MDU2NTIsIm5iZiI6MTcyNDcwNTM1MiwicGF0aCI6Ii8zMjQ0NDc5MS8zNDc5OTI3MTAtZjczNjBiZWItMDc1Ni00YTZiLWFmM2MtNjIwYjA2YjhmMjUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDIwNDkxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkMGI4ZThjMzlkOWI2NzI1YjNkMWNjMDRhZjI3M2NiNjVkM2FiMjFmNjk2MzRkYjgwOWU0ZDZkMGYwYzhlY2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.q98PBQJaEcQbfQou400d_8u7lBqA_sMCCQYkg4BCLSk)
After:
![Screenshot 2024-07-11 at 4 53 04 PM](https://private-user-images.githubusercontent.com/32444791/347992152-56332f77-337c-4571-83d4-d26d6b297517.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MDU2NTIsIm5iZiI6MTcyNDcwNTM1MiwicGF0aCI6Ii8zMjQ0NDc5MS8zNDc5OTIxNTItNTYzMzJmNzctMzM3Yy00NTcxLTgzZDQtZDI2ZDZiMjk3NTE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDIwNDkxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkZjcyZTQwZDNiZDA2OGVhMDUyOGRlNTUxNjk3MmM2ZDkxYTQzZDRjNjY1MjE1NDYyMmQ3MjFlNmZhOWZkZTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fBYj8y0XVMQZNfJazckSgT4ecRLLpJNV8mb8Ceacfmg)
![Screenshot 2024-07-11 at 4 55 54 PM](https://private-user-images.githubusercontent.com/32444791/347992620-dd9bc2ab-3e4a-4f84-b237-26fa942ecf35.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MDU2NTIsIm5iZiI6MTcyNDcwNTM1MiwicGF0aCI6Ii8zMjQ0NDc5MS8zNDc5OTI2MjAtZGQ5YmMyYWItM2U0YS00Zjg0LWIyMzctMjZmYTk0MmVjZjM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDIwNDkxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI0YjYwMjg4MGI0ZTgwYzY4MGI4YjkxZjMzMGZjMTVmNzg5MGIyM2E5NzNkOTRlYWIzNGIwZDE3YmM5NGI2MjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yB3gJnVoch7QTfPxMHVkzHHrJKNTxTsv0JDmhcppe5s)