Fix terraform template name #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Jul 11, 2024
...dels/manageiq/providers/embedded_terraform/automation_manager/configuration_script_source.rb
Show resolved
Hide resolved
|
@agrare Please review. |
|
Note that in @GilbertCherrie 's screenshot the name of his repository is |
agrare
reviewed
Jul 11, 2024
...dels/manageiq/providers/embedded_terraform/automation_manager/configuration_script_source.rb
Outdated
Show resolved
Hide resolved
GilbertCherrie
force-pushed
the
fix_template_name
branch
7 times, most recently
from
c60f5e9
to
df6551e
Compare
GilbertCherrie
force-pushed
the
fix_template_name
branch
from
df6551e
to
ae80102
Compare
|
Checked commit GilbertCherrie@ae80102 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Jul 11, 2024
Fryguy
reviewed
Jul 15, 2024
| expect(names.first).to(eq("hello_world_local(master):#{local_repo}/")) | ||
| expect(names.first).to(eq("/hello_world_local")) |
There was a problem hiding this comment.
This is a little weird that the names for non-folder-based ones have a leading slash - we should probably remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix terraform template name.
Before:
After:
