Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mising metrics authentication #109

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 5, 2017

Description

Currently a miq queue request to authenticate a container provider will not authenticate all endpoints, missing endpoints are "hawkular" and "prometheus"

Screenshots
Before fix
screenshot-5b7fd941-f833-4da3-bedb-5e20f2fd793d-2017-09-05-13-50-10

After fix
screenshot-5b7fd941-f833-4da3-bedb-5e20f2fd793d-2017-09-05-13-49-43

@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2017

@miq-bot add-labels bug

@zeari @cben @moolitayer @ilackarms @simon3z please review

@miq-bot miq-bot added the bug label Sep 5, 2017
@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2017

Checked commit yaacov@7fd05cc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer
Copy link

moolitayer commented Sep 5, 2017

@bdunne it seems the label for sprint 69 is missing, do you know who should create it?

@bdunne
Copy link
Member

bdunne commented Sep 6, 2017

I believe @Fryguy can create that for us.

@Fryguy Fryguy added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants