Prefix ems_ref with object type in event hash #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event handler expects the ems_ref to be prefixed by the object type, not using the raw ems_ref. This is causing issues adding a real ems_ref for an event because the process_container_entities_in_event! method is clearing the key.
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Sep 29, 2017
Use the class name as a prefix for ems_ref removing a collision with the real ems_ref column Depends on ManageIQ/manageiq-providers-kubernetes#123 Fixes ManageIQ#16074
This was referenced Sep 29, 2017
|
Checked commit agrare@f706759 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Sep 29, 2017
Use the class name as a prefix for ems_ref removing a collision with the real ems_ref column Depends on ManageIQ/manageiq-providers-kubernetes#123 Fixes ManageIQ#16074
moolitayer
reviewed
Oct 1, 2017
| @@ -4,7 +4,16 @@ module ManageIQ::Providers::Kubernetes::ContainerManager::EventParserMixin | |||
| included do | |||
| def self.event_to_hash(event, ems_id = nil) | |||
| _log.debug("ems_id: [#{ems_id}] event: [#{event.inspect}]") | |||
| { | |||
| ems_ref_key = case event[:kind] | |||
|
@agrare The fix makes sense. What I don't get is what Is a real ems_ref? Do we have a bug or issue for this or is it for something under development? |
|
IIUC this better be merged simultaneously with ManageIQ/manageiq#16076 |
cben
approved these changes
Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event handler expects the ems_ref to be prefixed by the object type,
not using the raw ems_ref. This is causing issues adding a real ems_ref
for an event because the process_container_entities_in_event! method is
clearing the key.