Add a setting to only send DELETED notices

[agrare]

This adds a setting to the InventoryCollectorWorker which allows for only DELETED pod notices to be sent, thus reducing the traffic hitting MiqQueue.

[moolitayer]

@agrare can you please explain why/when :deleted_notices_only: true is useful?
(does not seem to give what you originally made the watch for)

[Ladas]

I wonder if we should rather expose what types to store? filter_notice_types: ['DELETED', ...] . As it might be ok to do DELETED + MODIFIED for g-release?

[moolitayer]

thought about that too, I'm good with making it more complex when you have use for it

[Ladas]

ok

[agrare]

@moolitayer the content of the delete notice also still has the full spec of the pod so we can create the pod record from just the deletes. If we only care about not missing a pod then this will satisfy that.
I left it default to false so that we can get better testing of how the queue reacts to a large number of targets then we can switch it back before release if we want.

[moolitayer]

I left it default to false so that we can get better testing of how the queue reacts to a large number of targets then we can switch it back before release if we want.

If we plan to release with true It's seems desired to test if the delete really is enough for the metrics collection too. If that should be enough for us maybe we don't need to stress + test the queue any more then that?

[Ladas]

@agrare @moolitayer makes sense to switch on true by default and test mainly that. We can test with false on some big env later.

[miq-bot]

Checked commit agrare@a210725 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[agrare]

Okay defaulted to true

[Ladas]

👍

[moolitayer]

LGTM 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit b947c1aa7af2ef31aad6a0a831157dd40629793d
Author: Mooli Tayer <mtayer@redhat.com>
Date:   Thu Nov 2 15:49:17 2017 +0200

    Merge pull request #154 from agrare/setting_to_only_send_deleted_notices
    
    Add a setting to only send DELETED notices
    (cherry picked from commit 41a8bbeb45e6849b418a3f78d0377cb23f45528e)