Convert the duration to a float #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread#join used to accept duration objects but not since ruby 3/rails 6.1 See also ManageIQ/manageiq-providers-vmware#832
|
Checked commit jrafanie@4ddd1ee with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Fryguy
approved these changes
Jun 26, 2023
agrare
approved these changes
Jun 26, 2023
Fryguy
reviewed
Jun 26, 2023
| @@ -31,7 +31,7 @@ def stop!(join_limit = 10.seconds) | |||
|
|
|||
| finish.make_true | |||
| watch&.finish rescue nil | |||
| thread&.join(join_limit) | |||
| thread&.join(join_limit.to_f) | |||
There was a problem hiding this comment.
Can you also change the incoming default parameter to just 10.0? This way we're not needlessly creating a duration only to convert it. We still need the .to_f, in case the incoming parameter is not a float.
def stop!(join_limit = 10.0) # 10 seconds
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jun 28, 2023
Convert the duration to a float (cherry picked from commit 1371d53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread#join used to accept duration objects but not since ruby 3/rails 6.1
See also ManageIQ/manageiq-providers-vmware#832