Added Helper Text To the Token Field

[DavidResende0]

Adds some text to the Token Field notifying the user that the Default, Metrics, and Alerts endpoints must be revalidated anytime the Token is updated if that endpoint is enabled.

Before:

After:

The long term goal is to add a clearer visual cue that illustrates this fact to the user.

[DavidResende0]

@miq-bot assign @Fryguy

[DavidResende0]

@agrare

[Fryguy]

Looks good to me - another option:

Suggested change

	:helperText => _('Note that the Default, Metrics, and Alert Endpoints, if enabled, must be revalidated every time the token is changed or updated'),
	:helperText => _('NOTE: The Default, Metrics, and Alert Endpoints, if enabled, must be revalidated every time the token is changed or updated'),

[Fryguy]

@dehawkins512 or @rwellon can you give suggestions for wording here, or if it's ok give it a 👍 ?

[agrare]

Spec failures look unrelated, failing on master for the last two days

[agrare]

@kbrock it seems like ManageIQ/manageiq@f7f3bdb caused the ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/rollup_spec.rb spec to start failing, haven't looked into it at all yet just FYI

[rwellon]

@Fryguy
Suggested text:

 :helperText => _('Note: If enabled, the Default, Metrics, and Alert Endpoints must be revalidated whenever the token is changed or updated'),

[agrare]

whenever the token is changed or updated

What is the difference between changed/updated? I think we could go with one or the other but not both

[DavidResende0]

whenever the token is changed or updated

What is the difference between changed/updated? I think we could go with one or the other but not both

@rwellon, @agrare Which one do you think is better?

[Fryguy]

Good question - We can probably choose one or the other. @rwellon Opinion here?

FWIW, I know @DavidResende0 was trying to handle both "new" and "edit" screens, so the wording needs to work for both.

[agrare]

so the wording needs to work for both.

So how about "when adding or changing the token"

[kbrock]

think this test failure has been fixed if you rebase this PR.

[agrare]

@DavidResende0 can you update the text per #498 (comment)

[DavidResende0]

@DavidResende0 can you update the text per #498 (comment)

New text -> Note: If enabled, the Default, Metrics, and Alert Endpoints must be revalidated when adding or changing the token

[miq-bot]

Checked commit DavidResende0@5d26725 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[Fryguy]

Backported to petrosian in commit dd8188e.

commit dd8188e5df8fb1c9810c96f36ff9d07f3ccd704c
Author: Adam Grare <adam@grare.com>
Date:   Wed Jul 26 12:42:59 2023 -0400

    Merge pull request #498 from DavidResende0/add-helper-text-to-token-field
    
    Added Helper Text To the Token Field
    
    (cherry picked from commit 6f5fb86495405f2a2259f1291a5240f46f3510a1)