Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test az_to_cn method in vmware #177

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Test az_to_cn method in vmware #177

merged 1 commit into from
Jan 22, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jan 19, 2018 •
edited
Loading

PR ManageIQ/manageiq#16811 adds RBAC filtering to allowed_cloud_network base class and vmware needed specs around the fact that the cloud network list is NOT dependent on availability zone choice unlike azure and amazon. (Per ManageIQ/manageiq#16824 (comment))

Related bz links:
https://bugzilla.redhat.com/show_bug.cgi?id=1533277
https://bugzilla.redhat.com/show_bug.cgi?id=1535189

@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 19, 2018

@miq-bot assign @bronaghs
@miq-bot add_label test

@miq-bot miq-bot added the test label Jan 19, 2018
@bronaghs bronaghs assigned agrare and unassigned bronaghs Jan 19, 2018
@d-m-u d-m-u force-pushed the add_test_for_cloud_network_method branch from 31dd9eb to 115385a Compare January 19, 2018 17:16
@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Some comments on commit d-m-u@115385a

spec/models/manageiq/providers/vmware/cloud_manager/provision_workflow_spec.rb

  • ⚠️ - 10 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 9 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Checked commit d-m-u@115385a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit d417fee into ManageIQ:master Jan 22, 2018
@agrare agrare added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 22, 2018
simaishi pushed a commit that referenced this pull request Mar 22, 2018
@agrare @simaishi
Merge pull request #177 from d-m-u/add_test_for_cloud_network_method
2f654b0 
Test az_to_cn method in vmware
(cherry picked from commit d417fee)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2f654b050fb45a2ee41c0678ac84aa779f4237f8
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Jan 22 10:14:24 2018 -0500

    Merge pull request #177 from d-m-u/add_test_for_cloud_network_method
    
    Test az_to_cn method in vmware
    (cherry picked from commit d417fee7b3ae64cf4c2a3c9a5e719de243d088bf)

@miq-bot miq-bot assigned bronaghs and unassigned agrare Mar 22, 2018
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@gmcculloug
Merge pull request ManageIQ#177 from billfitzgerald0120/vmmigrate_ema…
07fe288 
…il_fix

Fix VM Migrate complete email when To field is nil.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@bronaghs bronaghs

Labels
gaprindashvili/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @simaishi @agrare @bronaghs