Create container_quota_scopes table #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeari @gtanzillo @Fryguy please review, want to get at least schema before freeze. |
|
This pull request is not mergeable. Please rebase and repush. |
https://kubernetes.io/docs/concepts/policy/resource-quotas/#quota-scopes We don't yet store them, but should. ContainerQuota has_many (0 or more) container_quota_scopes. Each scope is a string (currently enum with 4 possible values). https://bugzilla.redhat.com/show_bug.cgi?id=1504560
|
Checked commit cben@c8f0a5b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
rebased, switched to standard |
This was referenced Dec 18, 2017
|
Note to self: I forgot to index This could slow down refresh (and display) if there will be tons of archived rows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kubernetes.io/docs/concepts/policy/resource-quotas/#quota-scopes
We don't yet store them, but should.
ContainerQuota has_many scopes, each a string (currently enum with 4 possible values
Terminating,NotTerminating,BestEffort,NotBestEffort).Didn't see any reason to choose clever serialized/json representation so went with standard has_many to new table.
See #110 for motivation having created_at/deleted_on.
https://bugzilla.redhat.com/show_bug.cgi?id=1504560