Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carbon 10 navbar & menu #6963

Merged
merged 57 commits into from
Jun 6, 2020
Merged

Carbon 10 navbar & menu #6963

merged 57 commits into from
Jun 6, 2020

Commits on Jun 4, 2020

  1. Replace MainMenu with a carbon wrapper 

    and adding a css hack to distinguish sub-sections from sections
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0a38946 View commit details
    Browse the repository at this point in the history

  2. Remove old specs

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f87c48c View commit details
    Browse the repository at this point in the history

  3. Navbar component - wraps navbar, menu, notifications/toasts 

    todo the navbar/notification/toasts parts
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    873fcd9 View commit details
    Browse the repository at this point in the history

  4. Menu icons - display, cleanup 2nd level 

    previous menu only displayed icons for first-level sections,

some 2nd level sections have icons which don't exist, or are the same as every other icon in the section, removing
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    e143594 View commit details
    Browse the repository at this point in the history

  5. MainMenu - simplify props 

    check what we need in the individual items and sections,
removing the need for overly specific shapes on MainMenu
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    e5c4218 View commit details
    Browse the repository at this point in the history

  6. NotificationDrawer, ToastList - both can live outside Navbar 

    ToastList renders completely independently

NotifiactionDrawer inherits height,
so we can either override height and position down to align with the bottom of navbar,
or move it outside and position up to align, better.
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3fe5897 View commit details
    Browse the repository at this point in the history

  7. NotificationDrawer sizing fix

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0d2b1ae View commit details
    Browse the repository at this point in the history

  8. Navbar - integrate navbar header

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    7b1fe79 View commit details
    Browse the repository at this point in the history

  9. _header - no separate helpMenu or userMenu

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    32c46c0 View commit details
    Browse the repository at this point in the history

  10. Menu - merge help and settings sections 

    also adds the Configuration button back to the menu, this time as Application Settings
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    1abac90 View commit details
    Browse the repository at this point in the history

  11. TopNavbar - remove old configuration, help menu, user menu code

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0047481 View commit details
    Browse the repository at this point in the history

  12. Notifications - move toggle to breadcrumbs, fix styling 

    make the breadcrumbs narrower, use the rest for the notification button,
the badge styling didn't work, replaced with color for the bell when unread

no margins would be nice but we have no such buttons
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f26ea54 View commit details
    Browse the repository at this point in the history

  13. menu.{Navbar,MainMenu} - separate, move everything to the right place

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    63dfcc8 View commit details
    Browse the repository at this point in the history

  14. Remove obsolete styles - masthead, custom_logo, vertical_navigation 

    and move the menu and notification styling to webpack
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    848608a View commit details
    Browse the repository at this point in the history

  15. Menu - add custom styling

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    4831f3c View commit details
    Browse the repository at this point in the history

  16. Menu - remember collapsed/expanded state, adjust body 

    using the original patternfly localStorage logic,
and added a miq-main-menu-{expanded,collapsed} body class that overrides patternfly default 225 px margin

and made the menu component update all those :)
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    e9935bb View commit details
    Browse the repository at this point in the history

  17. Menu - allow & use carbon icons 

    updated menu definition to use carbon icons where available,
and updated carbonizeIcon to recognize `carbon--Foobar` as `<Foobar20 />`
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f2fb918 View commit details
    Browse the repository at this point in the history

  18. menu styling - rem fix, use SideNavHeader, SideNavItem, chevron icons… 

    … in the right gray

setting the html font size changes the rem units to the actual carbon defaults,
so we get some menu sizing for free
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    4d07ab4 View commit details
    Browse the repository at this point in the history

  19. SideNavMenuItem - support renderIcon, same as SideNavMenu 

    not supported by default, but the logout item needs an icon,
and custom items can use it too
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f24d426 View commit details
    Browse the repository at this point in the history

  20. NotificationsToggle - use MiqIcon and carbon icons

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    6cc557b View commit details
    Browse the repository at this point in the history

  21. remove custom SideNavMenuItem, use SideNavLink for first level menu i… 

    …tems

that one can do icons by default
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    1c68ca8 View commit details
    Browse the repository at this point in the history

  22. Menu carbonize UserOptions, split into user bit and GroupSwitcher 

    GroupSwitcher should just be a SideNavSwitcher, except it doesn't handle options where value != label, and the chevron doesn't trigger it
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    944906e View commit details
    Browse the repository at this point in the history

  23. menu: use Search

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    25c0932 View commit details
    Browse the repository at this point in the history

  24. Menu - add second level 

    leaving first-level sections and items in the first SideNav,
but adding a second floaty SideNav when a section is selected,
and moved second and third level menu there

    SideNav
      SideNavLink (section, level 1)
      SideNavLink (section, level 1)
      SideNavLink (item, level 1)
    SideNav.second
      SideNavMenu (section, level 2)
        SideNavMenuItem (item, level 3)
        SideNavMenuItem (item, level 3)
      SideNavMenu (section, level 2)
      SideNavMenuItem (item, level 2)

(nothing does `setSection(null)` yet to hide the 2nd level nav)
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    163e943 View commit details
    Browse the repository at this point in the history

  25. menu - fix second level root item to use MenuItem, not Link

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a6373fa View commit details
    Browse the repository at this point in the history

  26. menu - rebase colors on theme 

    https://www.carbondesignsystem.com/guidelines/color/usage/
Gray 90 theme
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    251e864 View commit details
    Browse the repository at this point in the history

  27. add new menu logos - expanded and collapsed 

    manageiq-logo-inverse - logo+manageiq, horizontal, for dark background
manageiq-logo-glyph-inverse - just the logo, for dark background
brand - original brand, just minified

minified through [svgomg](https://jakearchibald.github.io/svgomg/)
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0d86a04 View commit details
    Browse the repository at this point in the history

  28. Menu - replace imagePath with logoLarge & logoSmall; add showLogo, sh… 

    …owUser

we're not using brand.svg in menu anymore,
replaced by separate files

added showLogo and showUser props, defaulting to true,
can be overidden from a plugin
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8019aa7 View commit details
    Browse the repository at this point in the history

  29. Menu - appearExpanded vs expanded 

    `expanded` is done explicitly by the user expanding or collapsing the whole menu,
persisted in storage

`appearExpanded` is what gets displayed

The menu *appears* expanded when displaying search results, or when a menu section is expanded, even if it would be collapsed otherwise.
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    9b2348d View commit details
    Browse the repository at this point in the history

  30. MenuSearch, SearchResults - search and display the results 

    does a case insensitive substring search on each item title, including parent titles ("compute clouds providers")
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    fc7cb69 View commit details
    Browse the repository at this point in the history

  31. menu Username - display username, convert to initials when collapsed

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ab8c2d5 View commit details
    Browse the repository at this point in the history

  32. menu color fixes

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    705d54e View commit details
    Browse the repository at this point in the history

  33. Menu FirstLevelSection - add chevrons

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    145a365 View commit details
    Browse the repository at this point in the history

  34. Menu - add overlay, clicking in menu hides sections 

    any click in the first level navigation that's not stopped will close the secondary navigation
so will any click on the overlay

and added the overlay
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    2be83e9 View commit details
    Browse the repository at this point in the history

  35. menu positioning - icon

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    57a05ad View commit details
    Browse the repository at this point in the history

  36. menu - reorganize into files, simplify first&second level, document

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    7ce55c3 View commit details
    Browse the repository at this point in the history

  37. menu username styling

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a98a701 View commit details
    Browse the repository at this point in the history

  38. Menu - ignore placement by default 

    new menu has no concept of placement,
but not removing yet
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b961aa2 View commit details
    Browse the repository at this point in the history

  39. Carbon spacing & color fixes

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    83fc416 View commit details
    Browse the repository at this point in the history

  40. menu - simulate hover effect on opened section 

    be in Overview > Dashboard,
click on Compute section,
move mouse to secondary menu

before: Compute is no longer highlighted, only Overview is
after: Overview is active, Compute has a fake hover effect
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    d55a9c2 View commit details
    Browse the repository at this point in the history

  41. Split off menu-colors from rest of menu css

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ff55409 View commit details
    Browse the repository at this point in the history

  42. menu - drop custom logo (not brand)

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    5a9ad77 View commit details
    Browse the repository at this point in the history

  43. cypress - fix menu helper; expose menu globally

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c6b7567 View commit details
    Browse the repository at this point in the history

  44. item-type: add noreferrer noopener rel to external links (help)

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    4f99c18 View commit details
    Browse the repository at this point in the history

  45. Fix breadcrumbs spec - needs redux for the notification button, updat… 

    …e snapshot

and made isDrawerVisible consistently a bool
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c4ee22c View commit details
    Browse the repository at this point in the history

  46. Breadcrumbs - split into original Breadcrumbs + BreadcrumbsBar with N… 

    …otificationToggle
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a7b37b3 View commit details
    Browse the repository at this point in the history

  47. nottificationsToggle: use classnames

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    4441de9 View commit details
    Browse the repository at this point in the history

  48. nottificationsToggle, searchResults: prefer {" "} over &nbsp;

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3f1607c View commit details
    Browse the repository at this point in the history

  49. group-switcher: use destructuring

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    92fb0d2 View commit details
    Browse the repository at this point in the history

  50. group-switcher: remove nested tertiary

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    fdc9057 View commit details
    Browse the repository at this point in the history

  51. main-menu: comment about useEffect having external effect

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    4c14fcf View commit details
    Browse the repository at this point in the history

  52. main-menu: change single prop components to oneliners 

    and set the linter rule accordingly
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    dae234f View commit details
    Browse the repository at this point in the history

  53. item-type: linter spacing fix

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    12e03ba View commit details
    Browse the repository at this point in the history

  54. second level menu - hide after clicking on items 

    needed for about modal & react router routes (because there's no full page reload to hide the secondary menu)
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    50f6bb1 View commit details
    Browse the repository at this point in the history

  55. menu: miqSparkleOn, miqSparkleOff for react routes

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    858589f View commit details
    Browse the repository at this point in the history

  56. breadcrumbs spec - fix import, update snapshot links

    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a875324 View commit details
    Browse the repository at this point in the history

  57. Menu - add history support for react router 

    basically v2v support, but it will work for any plugin which uses `.menu` and `HashRouter`
would need different, simpler `currentUrl` logic for `BrowserRouter`
    @himdel
    himdel committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    e2aab96 View commit details
    Browse the repository at this point in the history