Update node-sass, force newer node-gyp #6993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates node-sass to current version and trying to force our node-gyp to a version supporting python3, hoping it wins over the ^3.* dependency in node-sass.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/61b0a2b0a8c8a647c82d5782531ce2bb4887d32c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Related: sass/node-sass#2877 We may need to wait for node-sass 5.x to support python2-less builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates node-sass to current version
and trying to force our node-gyp to a version supporting python3,
hoping it wins over the ^3.* dependency in node-sass itself.
Related to ManageIQ/manageiq-pods#460
Cc @simaishi