Menu - drop SettingsLoader #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this essentially reverts #5617, and removes support for loading menu items from `Settings.ui.custom_menu`.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/5fad0b9cf6b102f408a88e3b51641ccce7cfdb5b with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
@himdel What's the motivation behind this change? |
|
Right, sorry, only that @chessbyte asked for it. (And if we don't remove it, we would have to add a way to support making the custom items go before the logout button after #6963.) |
h-kataria
approved these changes
May 29, 2020
simaishi
pushed a commit
that referenced
this pull request
Jun 2, 2020
Menu - drop SettingsLoader (cherry picked from commit 4211196)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this essentially reverts #5617,
and removes support for loading menu items from
Settings.ui.custom_menu.