Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Use a new rbac feature id for the menu item. #417

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Use a new rbac feature id for the menu item. #417

merged 1 commit into from
Jun 20, 2018

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jun 15, 2018 •
edited by simaishi
Loading

@martinpovolny martinpovolny mentioned this pull request Jun 15, 2018
Merged
@martinpovolny martinpovolny changed the title [WIP] Use a new rbac feature id for the menu item. Use a new rbac feature id for the menu item. Jun 15, 2018
@AllenBW AllenBW self-assigned this Jun 15, 2018
AllenBW
AllenBW approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the other pr makes it in, will merge this <3

@priley86
Copy link
Member

looks like this now needs a rebase after the plugin name change @martinpovolny

@martinpovolny
Copy link
Member Author

@priley86 : done

@AllenBW AllenBW merged commit d44b403 into ManageIQ:master Jun 20, 2018
@Fryguy Fryguy mentioned this pull request Jun 22, 2018
Closed
simaishi pushed a commit that referenced this pull request Jul 11, 2018
@AllenBW @simaishi
Merge pull request #417 from martinpovolny/menu_rbac_feature
8e403dc 
Use a new rbac feature id for the menu item.
(cherry picked from commit d44b403)

https://bugzilla.redhat.com/show_bug.cgi?id=1595413
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 8e403dccb9cdfe184d6d30b258da50799b6d2d32
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Wed Jun 20 08:28:34 2018 -0400

    Merge pull request #417 from martinpovolny/menu_rbac_feature
    
    Use a new rbac feature id for the menu item.
    (cherry picked from commit d44b403a99f626c55342471c8e12fb72c57db759)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1595413

This was referenced Jul 16, 2018
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@AllenBW AllenBW

@simaishi simaishi

Labels
blocker enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpovolny @priley86 @simaishi @AllenBW