Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Physical Infra Providers Menu Item #13587

Merged
merged 3 commits into from
Jan 31, 2017
Merged

Adding Physical Infra Providers Menu Item #13587

merged 3 commits into from
Jan 31, 2017

Conversation

juliancheal
Copy link
Member

@juliancheal juliancheal commented Jan 19, 2017 •
edited
Loading

Also adds start of translations. This PR is a requirement of a
follow up PR on the manageiq-classic-ui
screen shot 2017-01-19 at 17 50 17

This PR links to ManageIQ/manageiq-ui-classic#196

@juliancheal juliancheal changed the title Adding Physical Infra Providers Menu Item [WIP\ Adding Physical Infra Providers Menu Item Jan 19, 2017
@juliancheal juliancheal changed the title [WIP\ Adding Physical Infra Providers Menu Item [WIP] Adding Physical Infra Providers Menu Item Jan 19, 2017
@juliancheal juliancheal mentioned this pull request Jan 19, 2017
Merged
@chessbyte chessbyte added the wip label Jan 19, 2017
@AparnaKarve AparnaKarve force-pushed the ph_infra_pages branch 2 times, most recently from fe9c17a to 41434eb Compare January 26, 2017 17:04
Julian Cheal and others added 2 commits January 30, 2017 11:23
@AparnaKarve
Adding Physical Infra Providers Menu Item
7337a2e 
Also adds start of translations. This PR is a requirement of a
follow up PR on the manageiq-classic-ui
@AparnaKarve
Product Feature adjustments
eb0760a
@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2017

Checked commits juliancheal/manageiq@7337a2e~...7a25ba8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@AparnaKarve
Copy link
Contributor

AparnaKarve commented Jan 31, 2017 •
edited
Loading

@miq-bot remove_label wip

@blomquisg I think we should go ahead and merge this.
The UI PR -- ManageIQ/manageiq-ui-classic#196 depends on this.

Can you remove the WIP in the title? Since I'm not the original PR author, I can't update the title.
Thanks.

@miq-bot miq-bot removed the wip label Jan 31, 2017
@blomquisg blomquisg merged commit 98394e9 into ManageIQ:master Jan 31, 2017
@blomquisg blomquisg added this to the Sprint 54 Ending Feb 13, 2017 milestone Jan 31, 2017
@blomquisg blomquisg changed the title [WIP] Adding Physical Infra Providers Menu Item Adding Physical Infra Providers Menu Item Jan 31, 2017
@geertj
Copy link

geertj commented Feb 9, 2017

Now that we have "physical infrastructure," I think you need to qualify "Infrastructure" otherwise it gets weird. Also I would change the order to get from physical to containers. So:

  • Physical Infrastructure
  • Virtual Infrastructure
  • Clouds
  • Containers

Thoughts?

@juliancheal
Copy link
Member Author

Completely agree. However @blomquisg and I have tried changing Infrastructure to virtual Infrastructure and it's not a simple case, there are so many instances throughout the code.

Wait I just wrote that, and you simply mean changing the label. :) Now that is definitely easier. I'll open up a PR where we can better discuss it.

@chargio
Copy link
Contributor

chargio commented Feb 9, 2017

Great!

Thanks

@juliancheal juliancheal mentioned this pull request Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

@dclarizio dclarizio Awaiting requested review from dclarizio

Assignees

@Fryguy Fryguy

Labels
enhancement providers/physical ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juliancheal @miq-bot @AparnaKarve @geertj @chargio @blomquisg @Fryguy @chessbyte