use task queue for update stack operation #13897
Conversation
Update stack should use the task queue for direct operation on the provider (used by scaling/scaledown UI in ems infra) This commit includes the necessary model changes.
|
Checked commit sseago@88d5247 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good to me. @bzwei Any comments? |
| @@ -85,6 +85,22 @@ def raw_update_stack(_template, _options = {}) | |||
| raise NotImplementedError, _("raw_update_stack must be implemented in a subclass") | |||
| end | |||
|
|
|||
| def update_stack_queue(userid, template, options = {}) | |||
There was a problem hiding this comment.
Where does this method get called?
If we add queue version to update, shouldn't we do the same to create and delete?
There was a problem hiding this comment.
@bzwei I've updated the ems_infra_controller scaling/scaledown actions to call this rather than raw_update_stack (as part of a larger mandate to remove any direct provider calls from UI controllers) -- you can see that in ManageIQ/manageiq-ui-classic#373
As for create/delete, it would make sense to add those, but so far (across all models) we have only added _queue methods for those provider actions that are actually called from the UI. At the moment nothing in the UI calls create or delete on orchestration stacks.
|
@sseago Is this meant for the Euwe release? Since there is no referenced BZ I will mark as |
|
@gmcculloug That's right. This isn't needed for Euwe. |
Update stack should use the task queue for direct operation on the
provider (used by scaling/scaledown UI in ems infra)
This commit includes the necessary model changes.