Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305

jameswnl · 2017-03-13T17:46:20Z

@miq-bot add_labels wip, enhancement, providers/ansible_tower

blomquisg · 2017-03-13T17:51:38Z

Granted this is early, but don't forget the update_in_provider_queue and delete_in_provider_queue methods.

blomquisg · 2017-03-13T18:44:27Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+    task_ids = EmsRefresh.queue_refresh_task(manager)
+    task_ids.each { |tid| MiqTask.wait_for_taskid(tid) }
+
+    reload!


I don't think this will work. There's no class level method reload!

> ManageIQ::Providers::AnsibleTower::AutomationManager::Credential.respond_to? :reload! => false

You could do something similar to the create_in_provider and return the updated inventory object.

This is an instance method

Do we want to make it as class method?

blomquisg · 2017-03-13T19:29:19Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+      queue(manager.my_zone, "create_in_provider", [manager_id, params], "Creating #{name}")
+    end
+
+    private


Surprisingly, this won't set the following class methods as private.

You'll have to do private_class_method :method_name in order to get private class methods.

it does!

I've updated my code to use send, or else it won't work

Maybe ActiveSupport::Concern is smarter. In general adding private for class methods doesn't do anything for the class methods. It only affects the instance methods' visibility.

Well, I'll be:

> ManageIQ::Providers::AnsibleTower::AutomationManager::Credential.private_methods.select {|m| ["queue", "refresh"].include? (m.to_s) } => [:refresh, :queue]

blomquisg · 2017-03-13T19:33:25Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

        :class_name  => name,
-        :method_name => "create_in_provider",
+        :method_name => method_name,


This won't work for the instance methods. You'll have to pass in the id of the current instance in order to have it look up the instance to call the method.

See here:

manageiq/app/models/miq_task.rb

Line 210 in db29ce2

# :instance_id (if using an instance method...an id)

yes!!!
It was in my mind, and it slippppped...

blomquisg · 2017-03-13T19:35:00Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+  end
+
+  def update_in_provider_queue(params)
+    self.class.send('queue', resource.my_zone, "update_in_provider", [params], "Updating #{self.class.name}")


Re: https://github.com/ManageIQ/manageiq/pull/14305/files#r105751307

For instance, here, you'd have to pass in the self.id as well as update_in_provider. Otherwise, it will try to call a class method update_in_provider, which doesn't exist.

blomquisg · 2017-03-13T19:40:48Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

    end

-    def create_in_provider_queue(manager_id, params)
+    def queue(my_zone, method_name, args, action)


I'd call my_zone just zone to avoid confusion with the my_zone method that exists in some contexts.

jameswnl · 2017-03-13T21:49:36Z

@miq-bot remove_label wip

blomquisg · 2017-03-14T14:21:11Z

...ls/manageiq/providers/ansible_tower/shared/automation_manager/configuration_script_source.rb

+
+    def create_in_provider_queue(manager_id, params)
+      manager = ExtManagementSystem.find(manager_id)
+      queue(manager.my_zone, nil, "create_in_provider", [manager_id, params], "Creating #{name}")


The last argument will be logged when creating the Queue item. Can you change that to include the ems_ref for the project being created? Something like "Creating #{name} with name #{params['name']}" maybe...

@blomquisg name or manager_ref(the native Tower ID), or id (vmdb record ID), which one is better?

So ended up using name here because this object is not created yet. The update/delete are using manager_ref now. Done!

blomquisg · 2017-03-14T14:22:22Z

...ls/manageiq/providers/ansible_tower/shared/automation_manager/configuration_script_source.rb

+  end
+
+  def update_in_provider_queue(params)
+    self.class.send('queue', manager.my_zone, id, "update_in_provider", [params], "Updating #{self.class.name}")


Same basic comment. The "Updating ..." action should contain an ID for the thing being updated. If there's an error in updating, we'll want to know which one caused the problem.

blomquisg · 2017-03-14T14:22:44Z

...ls/manageiq/providers/ansible_tower/shared/automation_manager/configuration_script_source.rb

+  end
+
+  def delete_in_provider_queue
+    self.class.send('queue', manager.my_zone, id, "delete_in_provider", [], "Deleting #{self.class.name}")


You probably know where this is going.

blomquisg · 2017-03-14T14:22:56Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+
+    def create_in_provider_queue(manager_id, params)
+      manager = ExtManagementSystem.find(manager_id)
+      queue(manager.my_zone, nil, "create_in_provider", [manager_id, params], "Creating #{name}")


Saga continues

blomquisg · 2017-03-14T14:23:08Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+  end
+
+  def update_in_provider_queue(params)
+    self.class.send('queue', resource.my_zone, id, "update_in_provider", [params], "Updating #{self.class.name}")


blomquisg · 2017-03-14T14:23:43Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/credential.rb

+  end
+
+  def delete_in_provider_queue
+    self.class.send('queue', resource.my_zone, id, "delete_in_provider", [], "Deleting #{self.class.name}")


https://www.pivotaltracker.com/story/show/140789269 https://www.pivotaltracker.com/story/show/138435555

miq-bot · 2017-03-14T16:32:31Z

Checked commits jameswnl/manageiq@a9303cd~...144c8de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍰

miq-bot added enhancement providers/ansible_tower wip labels Mar 13, 2017

blomquisg reviewed Mar 13, 2017

View reviewed changes

jameswnl force-pushed the api-UD-cred branch from 7a4321b to 6960409 Compare March 13, 2017 19:00

jntullo mentioned this pull request Mar 13, 2017

delete authentication in provider #14307

Merged

blomquisg reviewed Mar 13, 2017

View reviewed changes

jameswnl force-pushed the api-UD-cred branch from 6960409 to 6538856 Compare March 13, 2017 19:29

blomquisg reviewed Mar 13, 2017

View reviewed changes

jameswnl force-pushed the api-UD-cred branch 2 times, most recently from d9af78c to c29d667 Compare March 13, 2017 21:48

jameswnl changed the title ~~[WIP] To update/delete a Tower credential~~ To update/delete a Tower credential Mar 13, 2017

miq-bot removed the wip label Mar 13, 2017

Ansible Credential to update/delete in Tower

a9303cd

jameswnl force-pushed the api-UD-cred branch from c29d667 to a9303cd Compare March 13, 2017 22:47

Ansible Project to update/delete in Tower

ef933e8

jameswnl force-pushed the api-UD-cred branch from f464cf7 to ef933e8 Compare March 13, 2017 23:25

jameswnl changed the title ~~To update/delete a Tower credential~~ To update/delete a Tower credential/project Mar 13, 2017

jameswnl added 2 commits March 13, 2017 22:12

Spec for update/delete Credential through API

013f57c

Spec for update/delete Project through API

0ea77c4

jameswnl force-pushed the api-UD-cred branch from 4fd419b to 0ea77c4 Compare March 14, 2017 02:20

This was referenced Mar 14, 2017

Edit Authentications API #14319

Merged

delete and update configuration script sources #14323

Merged

blomquisg self-assigned this Mar 14, 2017

blomquisg reviewed Mar 14, 2017

View reviewed changes

Better action description for create/update/delete_in_provider_queue

144c8de

https://www.pivotaltracker.com/story/show/140789269 https://www.pivotaltracker.com/story/show/138435555

blomquisg approved these changes Mar 14, 2017

View reviewed changes

blomquisg merged commit bb9c250 into ManageIQ:master Mar 14, 2017

blomquisg added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 14, 2017

jameswnl deleted the api-UD-cred branch March 16, 2017 19:09

blomquisg changed the title ~~To update/delete a Tower credential/project~~ Create/Update/Delete Ansible Tower Projects and Credentials via queue Mar 29, 2017

Fryguy added the providers/automation label Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305

Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305

jameswnl commented Mar 13, 2017

blomquisg commented Mar 13, 2017

blomquisg Mar 13, 2017 •

edited

Loading

jameswnl Mar 13, 2017

jameswnl Mar 13, 2017

blomquisg Mar 13, 2017

blomquisg Mar 13, 2017

jameswnl Mar 13, 2017

blomquisg Mar 13, 2017

blomquisg Mar 13, 2017

blomquisg Mar 13, 2017

blomquisg Mar 13, 2017

jameswnl Mar 13, 2017 •

edited

Loading

blomquisg Mar 13, 2017

blomquisg Mar 13, 2017

jameswnl Mar 13, 2017

jameswnl commented Mar 13, 2017

blomquisg Mar 14, 2017

jameswnl Mar 14, 2017

jameswnl Mar 14, 2017

blomquisg Mar 14, 2017

blomquisg Mar 14, 2017

blomquisg Mar 14, 2017

blomquisg Mar 14, 2017

blomquisg Mar 14, 2017

miq-bot commented Mar 14, 2017

Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305

Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305

Conversation

jameswnl commented Mar 13, 2017

blomquisg commented Mar 13, 2017

blomquisg Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameswnl Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameswnl commented Mar 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Mar 14, 2017

blomquisg Mar 13, 2017 •

edited

Loading

jameswnl Mar 13, 2017 •

edited

Loading