Handle exception when a metrics target doesn't have an ext_management_system #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent a single target.perf_capture_queue exception from preventing the rest of the targets from being queued. If an invalid target made its way into the targets list and perf_capture_queue throws an exception then currently the remaining list of targets won't be queued. https://bugzilla.redhat.com/show_bug.cgi?id=1439888
|
If this is a common issue we should also fix https://github.com/ManageIQ/manageiq/blob/master/app/models/metric/targets.rb#L56 to not add invalid containers to the metric targets, cc @simon3z |
agrare
force-pushed
the
bz_1439888_metrics_collection_nil_queue_name
branch
from
fd8a7ba
to
be1cf3d
Compare
|
Checked commits agrare/manageiq@48c8a95~...be1cf3d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/metric/ci_mixin/capture.rb
|
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
…il_queue_name Handle exception when a metrics target doesn't have an ext_management_system (cherry picked from commit d7a82f2) https://bugzilla.redhat.com/show_bug.cgi?id=1441271
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
…il_queue_name Handle exception when a metrics target doesn't have an ext_management_system (cherry picked from commit d7a82f2) https://bugzilla.redhat.com/show_bug.cgi?id=1441272
|
Euwe backport details: |
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
…ection_nil_queue_name Handle exception when a metrics target doesn't have an ext_management_system (cherry picked from commit d7a82f2) https://bugzilla.redhat.com/show_bug.cgi?id=1441272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid target finds its way into
Metric::Capture.queue_capturesthe exception thrown will prevent all further targets from being queued. This will catch and log the exception for that target then continue to queue the remaining targets.Also since
Unsupported type ManageIQ::Providers::Kubernetes::ContainerManager::Container (id: 28453)isn't very descriptive of the real issue (the target type is fine, the specific target doesn't have an ems) this will raise an ArgumentError saying"target does not have an ExtManagementSystem"if the target doesn't have an ems_id or an old_ems_id.https://bugzilla.redhat.com/show_bug.cgi?id=1439888