Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated providers refresh to return all tasks for multi-manager providers #14747

Merged

Conversation

abellotti
Copy link
Member

Updated providers refresh to return the tasks in the action results when multiple managers have been targeted.

POST /api/providers/15
{
  "action" : "refresh"
}
{
  "success" : true,
  "message" : "Provider id:15 name:'sample_provider' refreshing",
  "href" : "/api/providers/15",
  "task_id" : 23,
  "task_href" : "/api/tasks/23",
  "tasks" : [
    { "id" : 23, "href" : "/api/tasks/23"},
    { "id" : 24, "href" : "/api/tasks/24"}
  ]
}

multiple managers have been targeted.

POST /api/providers/15
{
  "action" : "refresh"
}

{
  "success" : true,
  "message" : "Provider id:15 name:'sample_provider' refreshing",
  "href" : "/api/providers/15",
  "task_id" : 23,
  "task_href" : "/api/tasks/23",
  "tasks" : [
    { "id" : 23, "href" : "/api/tasks/23"},
    { "id" : 24, "href" : "/api/tasks/24"}
  ]
}
@abellotti abellotti force-pushed the api_provider_refresh_multi_managers branch from 321c814 to e72166b Compare April 13, 2017 13:10
@abellotti
Copy link
Member Author

@imtayadeway please review, Thanks!!

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commit abellotti@e72166b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@abellotti
Copy link
Member Author

ping @gtanzillo

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo merged commit 39b1dfc into ManageIQ:master Apr 19, 2017
@gtanzillo gtanzillo added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants