Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escalate privilege #14929

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Escalate privilege #14929

merged 2 commits into from
Apr 28, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Apr 27, 2017 •
edited by gmcculloug
Loading

Tower API accepts option :become_enabled to escalate privilege at job template creation. The flag will enable the escalation at job launching.

Will need UI work to add a checkbox for user to decide whether to enable this flag.

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1445377

@bzwei
Copy link
Contributor Author

bzwei commented Apr 27, 2017

@miq-bot enhancement, providers/ansible_tower, services, fine/yes
@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

@bzwei unrecognized command 'enhancement', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@bzwei
Copy link
Contributor Author

bzwei commented Apr 27, 2017

@miq-bot add_label enhancement, providers/ansible_tower, services, fine/yes

@bzwei
Copy link
Contributor Author

bzwei commented Apr 27, 2017

cc @h-kataria
UI needs to set config_info[:provision][:become_enabled] = true. Same for :retirement

@chrispy1
Copy link

@miq-bot add_label blocker

@gmcculloug gmcculloug requested a review from syncrou April 28, 2017 12:47
gmcculloug
gmcculloug reviewed Apr 28, 2017
View reviewed changes
app/models/service_template_ansible_playbook.rb Outdated
@@ -104,7 +104,7 @@ def self.build_parameter_list(name, description, info)
:ask_limit_on_launch => true,
:ask_inventory_on_launch => true,
:ask_credential_on_launch => true
}
}.merge(info.slice(:become_enabled))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set this with the other parameters?
:become_enable => info[:become_enabled]
or if the API cannot support the property possibility being nil
:become_enable => info[:become_enabled] || false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way we can add more options easily, for example info.slice(:become_enabled, :allow_simultaneous)

@miq-bot
Copy link
Member

miq-bot commented Apr 28, 2017

Checked commits bzwei/manageiq@3bbbaaf~...fe94ea9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug merged commit 291254e into ManageIQ:master Apr 28, 2017
@gmcculloug gmcculloug added this to the Sprint 60 Ending May 8, 2017 milestone Apr 28, 2017
@bzwei bzwei deleted the escalate_privilage branch May 1, 2017 14:00
@h-kataria h-kataria mentioned this pull request May 1, 2017
Merged
simaishi pushed a commit that referenced this pull request May 1, 2017
@gmcculloug @simaishi
Merge pull request #14929 from bzwei/escalate_privilage
d5db6cd 
Escalate privilege
(cherry picked from commit 291254e)

https://bugzilla.redhat.com/show_bug.cgi?id=1447086
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

Fine backport details:

$ git log -1
commit d5db6cd5b2c907327db5343d9c7a3d96e7771a8e
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Apr 28 10:52:58 2017 -0400

    Merge pull request #14929 from bzwei/escalate_privilage
    
    Escalate privilege
    (cherry picked from commit 291254e928dd64a3e52caa9a07cb788ab62663c7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syncrou syncrou syncrou approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
blocker enhancement fine/backported lifecycle/services providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bzwei @miq-bot @chrispy1 @simaishi @syncrou @gmcculloug @Fryguy