Added support for expression methods #15537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
Jul 21, 2017
app/models/miq_ae_method.rb
Outdated
| @@ -33,6 +33,10 @@ def self.available_scopes | |||
| AVAILABLE_SCOPES | |||
| end | |||
|
|
|||
| def self.available_expression_objects | |||
| Rbac::Filterer::CLASSES_THAT_PARTICIPATE_IN_RBAC | |||
There was a problem hiding this comment.
@mkanoor This list is not the complete set I would expect to see. For example it does not show Vm, just the base model VmOrTemplate. I think it would be better to expose the list from the MiqExpression model MiqExpression.base_tables
That is the list Reporting uses: https://github.com/ManageIq/manageiq/blob/5cf8d1ffd0e9489f9a58ecb1223c3a816817dd76/app/models/miq_report.rb#L107
|
Checked commits mkanoor/manageiq@a02186c~...aa07b39 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gmcculloug please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression methods allow you to embed MiqExpressions as Automate Methods.
https://www.pivotaltracker.com/n/projects/1613499/stories/148625717
Original PR #6655