Support memory limit for RHV #15591
Support memory limit for RHV #15591
Conversation
|
@borod108 pls review |
|
@masayag looks good, some specs are failing, could it be some how related? (I don't think so) |
|
@miq-bot assign @martinpovolny |
|
@h-kataria could you review (and if ok, to merge ?) |
|
@gmcculloug changes look good to me, just wanted to run them by you, let me know if they look good to you. @masayag is there a before/after screenshot you can upload to this PR. |
|
@h-kataria see updated PR message for screenshots. |
| :memory_limit: | ||
| :description: Memory (MB) | ||
| :required: false | ||
| :notes: (Max limit is determined by Operating System type and Arch) |
There was a problem hiding this comment.
Overall this looks good, but wondering why abbreviate "Arch" here? If this is space related I would abbreviate "OS" (more commonly used) and spelling out "Architecture". Otherwise don't abbreviate either.
|
Looks good to merge once @gmcculloug comment on the notes text is addressed |
RHV 4.1 and above supports memory limit. This option is being exposed in the UI under the 'Hardware' section. https://bugzilla.redhat.com/show_bug.cgi?id=1461560
masayag
force-pushed
the
set_max_vm_memory
branch
from
d5bfb0f
to
35d118b
Compare
|
Checked commit masayag@35d118b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks, I'll merge now but please update the "After" image in the description to reflect the text change. |
|
@gmcculloug Thanks, the image is update with the latest change. |
|
@miq-bot add_label fine/yes |
|
Backported to Fine via Backported to Fine via #17608 |
RHV 4.1 and above supports memory limit.
This option is being exposed in the UI under the 'Hardware' section.
Depends on ManageIQ/manageiq-providers-ovirt#61
https://bugzilla.redhat.com/show_bug.cgi?id=1461560
Before:
After:
