Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storage feature to container administrator role #15689

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jul 31, 2017

the user with role EvmRole_container-administrator has access to Compute -> Infra -> Datastores -> Datastore Clusters according to the his feature 'storage_pod' but ownership of feature 'storage_pod' is not enough to display menu Compute -> Infra -> Datastores at all,
so I am adding to ability to display the menu. ('storage')

Compute -> Infra -> Datastores -> Datastore Clusters is accordion Compute -> Infra -> Datastores

before
screen shot 2017-07-31 at 15 25 25

after
screen shot 2017-07-31 at 15 18 13

please review @zakiva (I think it was intended, correct me if not)

@miq-bot assign @gtanzillo

@miq-bot add_label bug

you need also 'storage' feature because
feature 'storage_pod' is not under 'storage' so
in that case you will not able to see the menu
Compute -> Infra -> Datastores -> Datastore Clusters
@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2017

Checked commit lpichler@662a948 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@gtanzillo gtanzillo requested a review from zakiva August 1, 2017 13:53
@gtanzillo gtanzillo added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 8, 2017
@gtanzillo gtanzillo merged commit c35d979 into ManageIQ:master Aug 8, 2017
@lpichler lpichler deleted the add_storage_feature_to_container_administrator branch August 8, 2017 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants