ovn: introducing ovn as ovirt's network provider #15929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
approved these changes
Sep 4, 2017
|
@miq-bot assign @blomquisg |
|
needed by ManageIQ/manageiq-providers-ovirt#90 |
bdunne
requested changes
Sep 7, 2017
app/models/cloud_tenant.rb
Outdated
| @@ -5,7 +5,7 @@ class CloudTenant < ApplicationRecord | |||
| include NewWithTypeStiMixin | |||
| extend ActsAsTree::TreeWalker | |||
|
|
|||
| belongs_to :ext_management_system, :foreign_key => "ems_id", :class_name => "ManageIQ::Providers::CloudManager" | |||
| belongs_to :ext_management_system, :foreign_key => "ems_id", :class_name => "ExtManagementSystem" | |||
There was a problem hiding this comment.
You should be able to drop the :class_name since you're targeting all descendants, right?
|
@AlonaKaplan seems like just spec/models/ext_management_system_spec.rb specs need to be fixed, just add redhat_network to the lists and it should work |
AlonaKaplan
force-pushed
the
master
branch
4 times, most recently
from
411031b
to
a439653
Compare
bdunne
approved these changes
Oct 2, 2017
oVirts network provider has 'neutron like' api. Therefore, it has tenants. Since oVirt provider is infra provider (and not cloud provider), tenants had to be extracted to support infra provider as parent ems.
|
Checked commit AlonaKaplan@3d617e0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/factories/ext_management_system.rb
|
|
depends on ManageIQ/manageiq-providers-ovirt#90 |
AlonaKaplan
added a commit
to AlonaKaplan/manageiq-ui-classic
that referenced
this pull request
Oct 5, 2017
xeviknal
pushed a commit
to xeviknal/manageiq-ui-classic
that referenced
this pull request
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oVirts network provider has 'neutron like' api. Therefore, it has tenants.
Since oVirt provider is infra provider (and not cloud provider), tenants
had to be extracted to support infra provider as parent ems.