Fixed syntax with orderby in RSS Feed YAML files
#16493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was causing the orderby column and direction to be pulled in as a single symbol in stead of a hash causing a SQL error while generating the feed. https://bugzilla.redhat.com/show_bug.cgi?id=1501265
|
Checked commit gtanzillo@9b39936 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Fixed syntax with `orderby` in RSS Feed YAML files (cherry picked from commit 5522a1e) https://bugzilla.redhat.com/show_bug.cgi?id=1517826
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Feb 7, 2018
Fixed syntax with `orderby` in RSS Feed YAML files (cherry picked from commit 5522a1e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542577
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Fixed syntax with `orderby` in RSS Feed YAML files (cherry picked from commit 5522a1e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was causing the orderby column and direction to be pulled in as a single symbol instead of a hash causing a SQL error while generating the feed.
SQL before -
SELECT "event_streams".* FROM "event_streams" WHERE "event_streams"."type" IN ('EmsEvent') AND (event_type = 'VmPoweredOffEvent') ORDER BY "event_streams"."created_on :desc" ASC LIMIT $1After -
SELECT "event_streams".* FROM "event_streams" WHERE "event_streams"."type" IN ('EmsEvent') AND (event_type = 'VmPoweredOffEvent') ORDER BY "event_streams"."created_on" DESC LIMIT $1https://bugzilla.redhat.com/show_bug.cgi?id=1501265