Fixes a stack trace issue (500) during API authentication. #16520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abellotti
commented
Nov 21, 2017
abellotti
commented
- seems to happen in a very short window where the token is invalidated in the memcached from the time it is checked for and the time we get fields out of the token.
- stumbled into this scenario while attempting to reproduce bugzilla #1512839.
- seems to happen in a *very* short window where the token is invalidated in the memcached from the time it is checked for and the time we get fields out of the token. - stumbled into this scenario while attempting to reproduce bugzilla #1512839.
abellotti
added a commit
to abellotti/manageiq-api
that referenced
this pull request
Nov 21, 2017
as a token gets invalidated after its initial existence check. - complete fix also requires ManageIQ/manageiq#16520
abellotti
added a commit
to abellotti/manageiq-api
that referenced
this pull request
Nov 21, 2017
as it gets invalidated after its initial existence check. - complete fix also requires ManageIQ/manageiq#16520
|
Checked commit abellotti@44e220d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
added a commit
to abellotti/manageiq-api
that referenced
this pull request
Nov 22, 2017
as it gets invalidated after its initial existence check. - Requires ManageIQ/manageiq#16520 - Added spec
abellotti
changed the title
|
unwip - test included in ManageIQ/manageiq-api#223 |
gtanzillo
approved these changes
Nov 27, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 28, 2017
Fixes a stack trace issue (500) during API authentication. (cherry picked from commit fc8cfe5)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.