Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to call normalized_status #16578

Merged
merged 1 commit into from
Dec 1, 2017
Merged

No need to call normalized_status #16578

merged 1 commit into from
Dec 1, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Dec 1, 2017

@bzwei
Copy link
Contributor Author

bzwei commented Dec 1, 2017

@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @gmcculloug
@mkanoor please review

@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2017

Checked commit bzwei@628f316 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@mkanoor
Copy link
Contributor

mkanoor commented Dec 1, 2017

👍 @gmcculloug

@gmcculloug gmcculloug merged commit d66dbcc into ManageIQ:master Dec 1, 2017
@gmcculloug gmcculloug added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 1, 2017
@bzwei bzwei deleted the fix_log_stdout branch December 1, 2017 21:35
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@gmcculloug @simaishi
Merge pull request #16578 from bzwei/fix_log_stdout
6cd344d 
No need to call normalized_status
(cherry picked from commit d66dbcc)

https://bugzilla.redhat.com/show_bug.cgi?id=1520481
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit 6cd344d6f230a3e11fb797dfe5b6e25b178ea3f9
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Dec 1 16:21:37 2017 -0500

    Merge pull request #16578 from bzwei/fix_log_stdout
    
    No need to call normalized_status
    (cherry picked from commit d66dbccded14bee7d2f5f379c9b6270ca7b4e31a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug core gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzwei @miq-bot @mkanoor @simaishi @chessbyte @gmcculloug