Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Automate Git repos without master branch #16690

Merged
merged 2 commits into from
Feb 26, 2018

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Dec 19, 2017

In some of the Git repos the master branch might not exist. The code has been modified to check for the branch name stored in refs/heads instead of hardcoding it to master.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1508881

PR #16430

@gmcculloug
Copy link
Member

@mkanoor The description currently only states the problem. Please update the description to describe how this PR is addressing that problem.

@gmcculloug
Copy link
Member

@Fryguy Please review.

@Fryguy Fryguy merged commit 2b45079 into ManageIQ:master Feb 26, 2018
@Fryguy Fryguy added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 26, 2018
@Fryguy
Copy link
Member

Fryguy commented Feb 26, 2018

@gmcculloug @mkanoor Does this need to be gaprindashvili/yes?

@gmcculloug
Copy link
Member

Related BZ shows this should target Gaprindashvili and Fine. I'll add the labels, thanks.

simaishi pushed a commit that referenced this pull request Mar 5, 2018
Support Automate Git repos without master branch
(cherry picked from commit 2b45079)

https://bugzilla.redhat.com/show_bug.cgi?id=1551627
@simaishi
Copy link
Contributor

simaishi commented Mar 5, 2018

Fine backport details:

$ git log -1
commit b4a852def79a19120ed910765923a65c09315e56
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Feb 26 14:46:39 2018 -0500

    Merge pull request #16690 from mkanoor/fixed_hang_issues
    
    Support Automate Git repos without master branch
    (cherry picked from commit 2b45079611e9d17f2c1e5f0930cb17ede23b3fbc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1551627

simaishi pushed a commit that referenced this pull request Mar 7, 2018
Support Automate Git repos without master branch
(cherry picked from commit 2b45079)

https://bugzilla.redhat.com/show_bug.cgi?id=1551626
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 8dce13781843b85db7128cad9e615dc2711cba62
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Feb 26 14:46:39 2018 -0500

    Merge pull request #16690 from mkanoor/fixed_hang_issues
    
    Support Automate Git repos without master branch
    (cherry picked from commit 2b45079611e9d17f2c1e5f0930cb17ede23b3fbc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1551626

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
Support Automate Git repos without master branch
(cherry picked from commit 2b45079)

https://bugzilla.redhat.com/show_bug.cgi?id=1551627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants