Reconfigure VM: Add / Remove Network Adapters #16700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2017
|
This pull request is not mergeable. Please rebase and repush. |
|
@kruge002 Please rebase. |
|
@gmcculloug Thanks for your reply. I will fix this in the coming days. |
|
@gmcculloug Due to a shift in priorities this will take a bit longer. |
kruge002
force-pushed
the
ReconfigureNetwork
branch
from
e2a1ba2
to
65dba55
Compare
|
Checked commits kruge002/manageiq@65dba55~...3d5b4d9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good. Thanks @kruge002 |
|
@gmcculloug Can this be |
27 tasks
|
I for one, would love this to be backported, |
on G presently
|
@simaishi Label added. |
simaishi
pushed a commit
that referenced
this pull request
Jun 1, 2018
Reconfigure VM: Add / Remove Network Adapters (cherry picked from commit 6a0dc62)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to reconfigure network adapters at the Reconfigure VM webpage.
This PR is part of a set of PRs:
ManageIQ/vmware_web_service#25 (merged by @agrare)
ManageIQ/manageiq-providers-vmware#163
#16700
ManageIQ/manageiq-ui-classic#3121
More info: ManageIQ/manageiq-ui-classic#3119