Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #configuration_script because of virtual_has_one relationship #16923

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Implement #configuration_script because of virtual_has_one relationship #16923

merged 1 commit into from
Jan 31, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Jan 31, 2018 •
edited
Loading

Class Service needs to implement #configuration_script because of the virtual_has_one relationship.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540250

@bzwei
Copy link
Contributor Author

bzwei commented Jan 31, 2018

@miq-bot add_label bug, service
@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Jan 31, 2018

@bzwei Cannot apply the following label because they are not recognized: service

@miq-bot miq-bot added the bug label Jan 31, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 31, 2018

Checked commit bzwei@a6558c4 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug merged commit 3ebdb6a into ManageIQ:master Jan 31, 2018
@gmcculloug gmcculloug added this to the Sprint 79 Ending Feb 12, 2018 milestone Jan 31, 2018
@bzwei bzwei deleted the service_config_script branch January 31, 2018 22:21
simaishi pushed a commit that referenced this pull request Mar 6, 2018
@gmcculloug @simaishi
Merge pull request #16923 from bzwei/service_config_script
e8bb529 
Implement #configuration_script because of virtual_has_one relationship
(cherry picked from commit 3ebdb6a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552271
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit e8bb529b12a3f0887f201e5d9e8037df5a9e53dd
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Jan 31 17:17:12 2018 -0500

    Merge pull request #16923 from bzwei/service_config_script
    
    Implement #configuration_script because of virtual_has_one relationship
    (cherry picked from commit 3ebdb6a7f803a11c5820bad62ade3ae7e8ddd323)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzwei @miq-bot @simaishi @gmcculloug