[GAPRINDASHVILI] Add ArchivedMixin to ServiceTemplate #17481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
May 25, 2018
app/models/service_template.rb
Outdated
| include ReservedMixin | ||
| reserve_attribute :deleted_on, :datetime | ||
|
|
||
| scope :archived, -> { includes(:reserved_rec).select { |st| !st.deleted_on.nil? } } |
There was a problem hiding this comment.
Is there a better way to do scopes on reserved attributes?
agrare
force-pushed
the
gaprindashvili_add_deleted_on_to_service_template
branch
2 times, most recently
from
d209e74
to
425c0ff
Compare
|
This pull request is not mergeable. Please rebase and repush. |
agrare
force-pushed
the
gaprindashvili_add_deleted_on_to_service_template
branch
from
425c0ff
to
b9458b2
Compare
|
Checked commits agrare/manageiq@ea39fdb~...b9458b2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/service_template.rb
|
blomquisg
approved these changes
May 31, 2018
|
looks good to merge 👍 |
|
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1593890 @miq-bot add_label blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17480 using reserved attributes.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1594023