Move VIRTUAL_COL_USES translation to col_index method in ChargeableField #17747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
from
4c6afa6
to
ca8de9e
Compare
lpichler
force-pushed
the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
from
ca8de9e
to
07760c5
Compare
lpichler
changed the title
lpichler
force-pushed
the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
2 times, most recently
from
91e1387
to
5d04ec5
Compare
lpichler
force-pushed
the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
from
5d04ec5
to
d81064b
Compare
lpichler
force-pushed
the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
from
d81064b
to
485da7e
Compare
lpichler
changed the title
|
@miq-bot add_label blocker, chargeback @miq-bot assign @gtanzillo |
|
Checked commit lpichler@485da7e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Aug 1, 2018
lpichler
deleted the
fix_translation_from_v_derived_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects
branch
|
@lpichler Can this be |
|
@simaishi yes, @miq_bot add_label gaprindashvili/yes |
|
@miq-bot add-label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Aug 17, 2018
…d_cpu_total_cores_used_to_cpu_usage_rate_average_chargeback_for_projects Move VIRTUAL_COL_USES translation to col_index method in ChargeableField (cherry picked from commit ee216b0) https://bugzilla.redhat.com/show_bug.cgi?id=1613295
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #17592
Chargeback for Projects is using
v_derived_cpu_total_cores_usedfrom yaml definition butwe are using from
MetricRollup#cpu_usage_rate_averageto get metric value and use it in chargeback calculation.But reason why it was not caught by specs is that we were using
cpu_usage_rate_averagein rspec factories(instead ofv_derived_cpu_total_cores_usedas it is used in yaml) and thanks to that this case have not been covered.Links
https://bugzilla.redhat.com/show_bug.cgi?id=1602818