Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake locale:plugin:find fixes #17847

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

mzazrivec
Copy link
Contributor

Two fixes:

  • use args[:engine] rather than args.key?(:engine) -- for some reason the later would always return nil.
  • for non-existent plugin (e.g. type), print nice error rather than an ugly traceback.

@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2018

Checked commits mzazrivec/manageiq@f126582~...1d31c8b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny martinpovolny self-assigned this Sep 6, 2018
@martinpovolny martinpovolny added this to the Sprint 94 Ending Sept 10, 2018 milestone Sep 6, 2018
@martinpovolny martinpovolny merged commit a6ff81f into ManageIQ:master Sep 6, 2018
@mzazrivec mzazrivec deleted the locale_rake_fixes branch September 6, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants