Fix counts in log message in ConsumptionHistory #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after recent changes we in records such structure:
records = {11 => [22, 33, 44], 55 => [66, 77]} when
keys are ids of resources and arrays contains ids of
metric rollups and to fix issue (or make it some as before)
we have to count elements in the arrays.
records.flatten :
[11, [22,33,..], 55, [66,...]]
records.flatten :
[11, 22, 33,.., 55, 66]
but have to remove keys
records.flatten.flatten.count - records.keys.count
|
Checked commit lpichler@15cbee5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler can this be |
|
yes @miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
Fix counts in log message in ConsumptionHistory (cherry picked from commit 85cdfe6) https://bugzilla.redhat.com/show_bug.cgi?id=1623582
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1605912
@miq-bot assign @gtanzillo
@miq-bot add_label chargeback, bug