Add ems_cluster_id to vms returned by validator #18011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AparnaKarve
approved these changes
Sep 21, 2018
|
/cc @gmcculloug |
|
Would be good to add a test to avoid losing it again. cc @lfu |
|
Thanks for the guidance with the test @AparnaKarve! |
michaelkro
force-pushed
the
add-ems-cluster-id-to-vms
branch
from
dfeae04
to
e40fbcd
Compare
|
Checked commits michaelkro/manageiq@407d7da~...e40fbcd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute was added in #17876,
but accidentally left out of the refactor done in #17364
This is necessary for creating
ServiceTemplateTransformationPlanwith OSP as a target provider in manageiq-v2v