Use images to get registry pods using the registry instead of running it.

[yaacov]

Description

Currently, number of pods is the number of pods that run the registry-service.
It makes more seance that number of pods will count the number of pods using the registry-service.

This PR changes the meaning of Container Pods from running the registry to using it.

Screenshot

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1599696

[yaacov]

@cben @Ladas @agrare please review

[Ladas]

👍

[agrare]

@yaacov IDK about changing the meaning of an existing field, though I agree I would have expected this to be the number of pods using not running the registry.

Can we add another association for the old meaning?

has_many :service_container_groups, :through => :container_services, :as => :container_group or something? Not sure what best to call it.

[yaacov]

@agrare @cben please re-review

[cben]

container_groups should definitely match containers, so 👍 to this change.

I don't think number of pods serving the registry would be useful for anyone, only increasing confusing (if one really needs, click the services). But adding an association is harmless as long as we don't show it :-)

I'd be in favor of renaming container_services to a better name, at least in the UI. But not in this PR.

[agrare]

I don't think number of pods serving the registry would be useful for anyone

Yeah this might very well be true, I just don't want someone to have e.g. built a report and now they can't get at the data at all.

[yaacov]

@agrare @cben update the inline docs, please re-review

[JPrause]

@miq-bot add_label blocker

[agrare]

Blocker? @yaacov this isn't a regression right?

[yaacov]

@agrare

Blocker?

the BZ is blocker: https://bugzilla.redhat.com/show_bug.cgi?id=1599696

@yaacov this isn't a regression right?

Yes not a regression, Dave Johnson asked it to be registered as one here: https://bugzilla.redhat.com/show_bug.cgi?id=1599696#c2

[agrare]

Okay thanks @yaacov I'll comment on the BZ.

[simaishi]

@yaacov @agrare hammer/yes ?

[agrare]

@simaishi updated

[simaishi]

Hammer backport details:

$ git log -1
commit 707c21e3477e06ab39b6ee420633bf9de9c2b4ef
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Oct 31 10:31:58 2018 -0400

    Merge pull request #18148 from yaacov/get-pods-from-images-instead-of-services
    
    Use images to get registry pods using the registry instead of running it.
    
    (cherry picked from commit 22f6e0974bd4960b4c40a4fc53a5403b48a174a0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1599696