Classification.yml don't use parent_id=0

[kbrock]

For seeds and import/exports, the levels explain the nesting, so
there is no need to pass parent_id: 0

This is part of the Classification.parent_id initiative #18301

[cben]

LGTM 👍

[kbrock]

@cben I truncated classifications, ran seeds and we had no parent_id => nil records.
I ran a second time and it didn't seem to update anything (this is good)

Any other tests you think would be good?

[Fryguy]

Will customers have exported data with non-zero parent_id values, and if so, will this de-parent those on re-import?

[cben]

Will customers have exported data with non-zero parent_id values

I'm aware of 3 export paths, all converge to export_to_array which always omitted parent_id on non-categories (since Initial commit). Also, they're always structured under entries:.

• tools/export_tags.rb -> Classification.export_to_yaml -> export_to_array
• https://github.com/rhtconsulting/cfme-rhconsulting-scripts/blob/master/rhconsulting_tags.rake also used Classification.export_to_yaml
• rake evm:export:tags -- --directory=d/ --all -> lib/task_helpers/export/tags.rb (based on the rhconsulting) also uses Classification.export_to_array

[kbrock]

@Fryguy ok - removed the hash delete. Anything else?

Thanks for the followup @cben

[miq-bot]

Checked commit kbrock@6c8d9ba with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

app/models/classification.rb

• ⚠️ - Line 378, Col 27 - Lint/UnneededSplatExpansion - Pass array contents as separate arguments.

[kbrock]

@Fryguy Think this is good to go. Anything else?

[kbrock]

@Fryguy If this is too much, I can pull out one or two small nuggets and try again.

[kbrock]

@Fryguy if you would prefer, I can remove the yaml file changes and just put in the code changes.

These changes need to be made for removing parent_id=0 stuff.
But regardless of those changes, these simplify the code and seem to make more sense to me.

We'll probably never put into place the change from parent_id=0 => parent_id=nil. So if you also want to punt on this PR just give the word.

Otherwise, let me know what I can do here to make this easier to grok

[cben]

@Fryguy These are not very important but they do simplify a subtle corner and would be nice to land